IGNITE-22994 Refactor subscription to activation/deactivation events … #11480
Conversation
…for internal components
.../main/java/org/apache/ignite/internal/processors/datastructures/DataStructuresProcessor.java
Show resolved
Hide resolved
...rg/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageImpl.java
Show resolved
Hide resolved
...va/org/apache/ignite/internal/processors/subscription/GridInternalSubscriptionProcessor.java
Show resolved
Hide resolved
| @@ -200,6 +200,8 @@ public GridTaskProcessor(GridKernalContext ctx) { | |||
| ctx.io().addMessageListener(TOPIC_TASK_CANCEL, new TaskCancelMessageListener()); | |||
| ctx.io().addMessageListener(TOPIC_TASK, new JobMessageListener(true)); | |||
|
|
|||
| ctx.internalSubscriptionProcessor().registerGlobalStateListener(this); | |||
There was a problem hiding this comment.
GridTaskProcessor is a GridComponent. Its onKernalStart() and onKernalStop() are called by IgniteKernal. We call twice onKernalStart(). Looks wierd. Should it be either GridComponent or IgniteChangeGlobalStateSupport but not both?
There was a problem hiding this comment.
In scope of refactoring we shouldn't change logic. It was called twice before changes, perhaps there is a reason for this.
| @@ -311,6 +311,8 @@ public GridEncryptionManager(GridKernalContext ctx) { | |||
| } | |||
| }); | |||
|
|
|||
| ctx.internalSubscriptionProcessor().registerGlobalStateListener(this); | |||
There was a problem hiding this comment.
GridEncryptionManager doesn't call onKernalStart on activation. As for GridTaskProcessor, investigation is required and this activity is out of scope of this ticket.
| @@ -200,6 +200,8 @@ public GridTaskProcessor(GridKernalContext ctx) { | |||
| ctx.io().addMessageListener(TOPIC_TASK_CANCEL, new TaskCancelMessageListener()); | |||
| ctx.io().addMessageListener(TOPIC_TASK, new JobMessageListener(true)); | |||
|
|
|||
| ctx.internalSubscriptionProcessor().registerGlobalStateListener(this); | |||
There was a problem hiding this comment.
In scope of refactoring we shouldn't change logic. It was called twice before changes, perhaps there is a reason for this.
...va/org/apache/ignite/internal/processors/subscription/GridInternalSubscriptionProcessor.java
Show resolved
Hide resolved
...rg/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageImpl.java
Show resolved
Hide resolved
.../main/java/org/apache/ignite/internal/processors/datastructures/DataStructuresProcessor.java
Show resolved
Hide resolved
|
…for internal components
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.