IGNITE-6141 JDBC: add basic support for BLOB and CLOB types #11492

skorotkov · 2024-08-22T10:10:55Z

Add simple support for BLOB/CLOB to thin JDBC driver and CLOB support to client JDBC driver.

Note, this implementation doesn't support the creation of LOBs via streams.

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

There is a single JIRA ticket related to the pull request.
The web-link to the pull request is attached to the JIRA ticket.
The JIRA ticket has the Patch Available state.
The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.

nizhikov · 2024-09-04T06:11:19Z

.../indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/IgniteH2Indexing.java

@@ -1090,14 +1091,14 @@ private List<? extends FieldsQueryCursor<List<?>>> executeDml(
            if (roEx != null) {
                throw new IgniteSQLException(
                    "Failed to execute DML statement. Cluster in read-only mode [stmt=" + qryDesc.sql() +
-                    ", params=" + Arrays.deepToString(qryParams.arguments()) + "]",
+                    ", params=" + S.toString(QueryParameters.class, qryParams) + "]",


Why this change?

If one of the query parameter is huge (say large CLOB/BLOB) usage of Arrays.deepToString does two "bad" things which increases heap memory usage:

creates full string representation of the large argument

once an exception is logged this large string is passed to logging framework

This can cause unneeded and unexpected OOM error just because of logging. The actual error is not logged in such case. Say I get the following error stack during testing:

[2024-08-29T22:03:37,692][ERROR][client-connector-#149%jdbc_thin_blob_test.JdbcThinLobTest.test_jdbc_thin_lob.blob_size.1073741824.clob_size.1024.server_heap.12.client_heap.8.ignite_version.dev%] .... java.lang.OutOfMemoryError: null at java.base/java.lang.AbstractStringBuilder.hugeCapacity(AbstractStringBuilder.java:214) ~[?:?] at java.base/java.lang.AbstractStringBuilder.newCapacity(AbstractStringBuilder.java:206) ~[?:?] at java.base/java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:173) ~[?:?] at java.base/java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:775) ~[?:?] at java.base/java.lang.StringBuilder.append(StringBuilder.java:252) ~[?:?] at java.base/java.util.Arrays.toString(Arrays.java:4988) ~[?:?] at java.base/java.util.Arrays.deepToString(Arrays.java:5189) ~[?:?] at java.base/java.util.Arrays.deepToString(Arrays.java:5161) ~[?:?] at org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing.executeDml(IgniteH2Indexing.java:1100)

On the other hand the S.toString handles huge strings and huge byte arrays with care. It skips most of the data and replaces it with elipsis. Like [1, 2, ... and 1073741724 more] for byte arrays and "aaa ... and 1041353 skipped ... aaa" for strings.

At the similar context SQL arguments are already logged this carefull way. See for example the JdbcQueryExecuteRequest::toString. If such a request is added into the log string the huge arguments are stripped.

.../indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/IgniteH2Indexing.java

nizhikov · 2024-09-04T06:13:10Z

...s/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/QueryParameters.java


 /**
 * Query parameters which vary between requests having the same execution plan. Essentially, these are the arguments
 * of original {@link org.apache.ignite.cache.query.SqlFieldsQuery} which are not part of {@link QueryDescriptor}.
 */
 public class QueryParameters {
    /** Arguments. */
+    @GridToStringInclude(sensitive = true)


Is this only field that will be printed out?
Don't we need other fields?

Yes, you are right. It worth adding all parameters as well.

Looks like In current code the QueryParameters are not logged as a whole. Only as the qryParams.arguments().

But adding other parameters should not break anything and would add more info for errors analisys.

Wil add.

nizhikov · 2024-09-04T07:11:14Z

modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBlob.java

@@ -54,7 +54,7 @@ public JdbcBlob(byte[] arr) {
    @Override public byte[] getBytes(long pos, int len) throws SQLException {
        ensureNotClosed();

-        if (pos < 1 || arr.length - pos < 0 || len < 0)
+        if (pos < 1 || (arr.length - pos < 0 && arr.length > 0) || len < 0)


Can you, please, clarify - why do we need new clause arr.length > 0?

It's needed to support the empty Blobs (blobs backed by an empty array).

Such blobs are returned from the java.sql.Connection::createBlob() which is a standard way to get blob from arbitrary JDBC driver. It also may be created via the concrete constructor as well like in the unittest below:

blob = new JdbcBlob(new byte[0]); assertEquals(0, blob.getBytes(1, 0).length);

This is a correct code according to java.sql.Blob contract.

The corrsponding testcase was added into the file modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcBlobTest.java in this PR.

nizhikov · 2024-09-04T07:36:02Z

modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcClob.java

+    @Override public String getSubString(long pos, int len) throws SQLException {
+        ensureNotClosed();
+
+        if (pos < 1 || len < 0 || pos - 1 + len > chars.length())


Can we cast pos to standard value as a first step to overcome API inconsistency and make code more readable:

pos = pos - 1; if (pos < 0 || len < 0 || pos + len > chars.length()) throw new SQLException("Invalid argument. Position should be greater than 0. Length should not be " + "negative. Position + length should be less than CLOB size [pos=" + (pos+1) + ", length=" + len + ']'); return chars.substring((int)pos, (int)pos + len);

nizhikov · 2024-09-04T07:46:58Z

modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcClob.java

+/**
+ * CLOB implementation for Ignite JDBC driver.
+ */
+public class JdbcClob implements Clob {


Let's fix all pos argument somehow to make value 0 based and consistent with String and any other API.
For example, make copy of all methods with pos, like:

public String getSubString(int pos, int len) { return getSubStringInternal(pos - 1, len); } private getSubstringInternal(int pos, int len) { // 0 index based implementation. }

Can we migrate to the char[] based implementation?
It's not clear from the API, but looks like Reader getCharacterStream() or getAsciiStream() expects to see changes in underlying object if they happens after getCharacterStream() invocation.

I think it's not worth doing so for current basic and naive Clob support.

Say postgres jdbc driver just doesn't support any methods to change the Clob object at all. The mysql jdbc driver does almost the same as we do here - it creates streams around the underlying string. Oracle possibly does something else but it has a real Clob support on protocol and storage level, which ignite doesn't. In ignite Clob for now is just a thin wrapper around the Strings.

General JDBC application wouldn't create a stream to read data from Clob from ResutSet and change it at the same time. Especially considering the "JDBC Thin Driver is not thread safe".

As far as the char[] implementation it would increase the memory usage in the "read" case. It would require the creation of extra char[] array in the ResultSet::getClob. With current implementation just a string reference is passed and no extra memory is needed (especially if the get*Stream() APIs are used by the application).

nizhikov · 2024-09-04T08:09:42Z

modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcClobTest.java

+
+        clob.free();
+
+        try {


Can we use assertThrows here and below?

nizhikov · 2024-09-10T10:29:30Z

modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcClob.java

+    /**
+     * Internal setString implementation with zero-based position parameter.
+     */
+    private int setStringInternal(long zeroBasedPos, String str) {


Minor: Can we have int parameter instead of long? This will reduce cast count.

nizhikov · 2024-09-10T10:30:28Z

modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcClob.java

+    /**
+     * Internal setString implementation with zero-based position parameter.
+     */
+    private int setStringInternal(long zeroBasedPos, String str, int off, int len) {


Minor: Can we have int parameter instead of long? This will reduce cast count.

nizhikov · 2024-09-10T10:32:02Z

modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcClob.java

+                    encodeNextChunk();
+                }
+
+                int encoded_chunk_size = Math.min(len - i, buf.length - bufPos);


encoded_chunk_size -> encodedChunkSize

nizhikov · 2024-09-10T11:35:29Z

modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcClobTest.java

+    @Test
+    public void testGetAsciiStreamForNonAsciiDataReadByByte() throws Exception {
+        StringBuilder sb = new StringBuilder();
+        for (int i = 0; i < 10000; i++) {


do we really need 10000 copies of the string?
Let's help CI and keep 10 copies?

The idea was to cover all variants in the JdbcClob.Utf8EncodedStringInputStream.encodeNextChunk() implementaion.

I reduce this to 3277 in one of two testcases (the minimum which produces the malformed surrogate).

And change to 10 in another one.

nizhikov · 2024-09-10T11:37:57Z

...es/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcPreparedStatementSelfTest.java

+        while (rs.next()) {
+            if (cnt == 0)
+                assert rs.getInt("id") == 2;
+
+            cnt++;
+        }


Suggested change

while (rs.next()) {

if (cnt == 0)

assert rs.getInt("id") == 2;

cnt++;

}

assertTrue(rs.next());

assertEquals(2, rs.getInt("id"));

assertFalse(rs.next());

nizhikov · 2024-09-10T11:39:25Z

...es/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcPreparedStatementSelfTest.java

+        int cnt = 0;
+
+        while (rs.next()) {
+            if (cnt == 0)
+                assert rs.getInt("id") == 1;
+
+            cnt++;
+        }
+
+        assertEquals(1, cnt);


Suggested change

int cnt = 0;

while (rs.next()) {

if (cnt == 0)

assert rs.getInt("id") == 1;

cnt++;

}

assertEquals(1, cnt);

assertTrue(rs.next());

assertEquals(1, rs.getInt("id"));

assertFalse(rs.next());

nizhikov · 2024-09-10T11:40:33Z

modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcResultSetSelfTest.java

+        int cnt = 0;
+
+        while (rs.next()) {
+            if (cnt == 0) {
+                Blob blob = rs.getBlob("blobVal");
+                Assert.assertArrayEquals(blob.getBytes(1, (int)blob.length()), new byte[] {1});
+
+                blob = rs.getBlob(23);
+                Assert.assertArrayEquals(blob.getBytes(1, (int)blob.length()), new byte[] {1});
+            }
+
+            cnt++;
+        }
+
+        assert cnt == 1;


Suggested change

int cnt = 0;

while (rs.next()) {

if (cnt == 0) {

Blob blob = rs.getBlob("blobVal");

Assert.assertArrayEquals(blob.getBytes(1, (int)blob.length()), new byte[] {1});

blob = rs.getBlob(23);

Assert.assertArrayEquals(blob.getBytes(1, (int)blob.length()), new byte[] {1});

}

cnt++;

}

assert cnt == 1;

assertTrue(rs.next());

Blob blob = rs.getBlob("blobVal");

Assert.assertArrayEquals(blob.getBytes(1, (int)blob.length()), new byte[] {1});

blob = rs.getBlob(23);

Assert.assertArrayEquals(blob.getBytes(1, (int)blob.length()), new byte[] {1});

assertFalse(rs.next());

nizhikov · 2024-09-10T11:41:38Z

modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcResultSetSelfTest.java

+        int cnt = 0;
+
+        while (rs.next()) {
+            if (cnt == 0) {
+                Clob clob = rs.getClob("clobVal");
+                Assert.assertEquals("str", clob.getSubString(1, (int)clob.length()));
+
+                clob = rs.getClob(24);
+                Assert.assertEquals("str", clob.getSubString(1, (int)clob.length()));
+            }
+
+            cnt++;
+        }
+
+        assert cnt == 1;


Suggested change

int cnt = 0;

while (rs.next()) {

if (cnt == 0) {

Clob clob = rs.getClob("clobVal");

Assert.assertEquals("str", clob.getSubString(1, (int)clob.length()));

clob = rs.getClob(24);

Assert.assertEquals("str", clob.getSubString(1, (int)clob.length()));

}

cnt++;

}

assert cnt == 1;

assertTrue(rs.next());

Clob clob = rs.getClob("clobVal");

Assert.assertEquals("str", clob.getSubString(1, (int)clob.length()));

clob = rs.getClob(24);

Assert.assertEquals("str", clob.getSubString(1, (int)clob.length()));

assertFalse(rs.next());

nizhikov · 2024-09-10T11:44:23Z

...es/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcPreparedStatementSelfTest.java

+        while (rs.next()) {
+            if (cnt == 0)
+                assert rs.getInt("id") == 1;
+
+            cnt++;
+        }
+
+        assertEquals(1, cnt);


Suggested change

while (rs.next()) {

if (cnt == 0)

assert rs.getInt("id") == 1;

cnt++;

}

assertEquals(1, cnt);

assertTrue(rs.next());

assertFalse(rs.next());

nizhikov · 2024-09-10T11:48:08Z

...les/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinPreparedStatementSelfTest.java

+        int cnt = 0;
+
+        while (rs.next()) {
+            if (cnt == 0)
+                assert rs.getInt("id") == 1;
+
+            cnt++;
+        }
+
+        assertEquals(1, cnt);


Suggested change

int cnt = 0;

while (rs.next()) {

if (cnt == 0)

assert rs.getInt("id") == 1;

cnt++;

}

assertEquals(1, cnt);

assertTrue(rs.next());

assertEquals(1, rs.getInt("id");

assertFalse(rs.next());

nizhikov · 2024-09-10T11:48:25Z

...les/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinPreparedStatementSelfTest.java

+        cnt = 0;
+
+        while (rs.next()) {
+            if (cnt == 0)
+                assert rs.getInt("id") == 2;
+
+            cnt++;
+        }
+
+        assert cnt == 1;


Suggested change

cnt = 0;

while (rs.next()) {

if (cnt == 0)

assert rs.getInt("id") == 2;

cnt++;

}

assert cnt == 1;

assertTrue(rs.next());

assertEquals(2, rs.getInt("id");

assertFalse(rs.next());

nizhikov · 2024-09-10T11:49:12Z

...les/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinPreparedStatementSelfTest.java

+        int cnt = 0;
+
+        while (rs.next()) {
+            if (cnt == 0)
+                assert rs.getInt("id") == 1;
+
+            cnt++;
+        }
+
+        assertEquals(1, cnt);


Suggested change

int cnt = 0;

while (rs.next()) {

if (cnt == 0)

assert rs.getInt("id") == 1;

cnt++;

}

assertEquals(1, cnt);

assertTrue(rs.next());

assertEquals(1, rs.getInt("id");

assertFalse(rs.next());```

nizhikov · 2024-09-10T11:49:37Z

...les/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinPreparedStatementSelfTest.java

+        cnt = 0;
+
+        while (rs.next()) {
+            if (cnt == 0)
+                assert rs.getInt("id") == 2;
+
+            cnt++;
+        }
+
+        assert cnt == 1;


Suggested change

cnt = 0;

while (rs.next()) {

if (cnt == 0)

assert rs.getInt("id") == 2;

cnt++;

}

assert cnt == 1;

assertTrue(rs.next());

assertEquals(2, rs.getInt("id");

assertFalse(rs.next());

nizhikov · 2024-09-10T11:50:31Z

modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinResultSetSelfTest.java

+        int cnt = 0;
+
+        while (rs.next()) {
+            if (cnt == 0) {
+                Blob blob = rs.getBlob("blobVal");
+                Assert.assertArrayEquals(blob.getBytes(1, (int)blob.length()), new byte[] {1});
+
+                blob = rs.getBlob(16);
+                Assert.assertArrayEquals(blob.getBytes(1, (int)blob.length()), new byte[] {1});
+            }
+
+            cnt++;
+        }
+
+        assert cnt == 1;


Suggested change

int cnt = 0;

while (rs.next()) {

if (cnt == 0) {

Blob blob = rs.getBlob("blobVal");

Assert.assertArrayEquals(blob.getBytes(1, (int)blob.length()), new byte[] {1});

blob = rs.getBlob(16);

Assert.assertArrayEquals(blob.getBytes(1, (int)blob.length()), new byte[] {1});

}

cnt++;

}

assert cnt == 1;

assertTrue(rs.next());

Blob blob = rs.getBlob("blobVal");

Assert.assertArrayEquals(blob.getBytes(1, (int)blob.length()), new byte[] {1});

blob = rs.getBlob(16);

Assert.assertArrayEquals(blob.getBytes(1, (int)blob.length()), new byte[] {1});

assertFalse(rs.next());

nizhikov · 2024-09-10T11:51:38Z

modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinResultSetSelfTest.java

+        int cnt = 0;
+
+        while (rs.next()) {
+            if (cnt == 0) {
+                Clob clob = rs.getClob("clobVal");
+                Assert.assertEquals("str", clob.getSubString(1, (int)clob.length()));
+
+                clob = rs.getClob(17);
+                Assert.assertEquals("str", clob.getSubString(1, (int)clob.length()));
+            }
+
+            cnt++;
+        }
+
+        assert cnt == 1;


Suggested change

int cnt = 0;

while (rs.next()) {

if (cnt == 0) {

Clob clob = rs.getClob("clobVal");

Assert.assertEquals("str", clob.getSubString(1, (int)clob.length()));

clob = rs.getClob(17);

Assert.assertEquals("str", clob.getSubString(1, (int)clob.length()));

}

cnt++;

}

assert cnt == 1;

assertTrue(rs.next());

Clob clob = rs.getClob("clobVal");

Assert.assertEquals("str", clob.getSubString(1, (int)clob.length()));

clob = rs.getClob(17);

Assert.assertEquals("str", clob.getSubString(1, (int)clob.length()));

assertFalse(rs.next());

sonarqubecloud · 2024-09-10T16:37:23Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarCloud

skorotkov force-pushed the IGNITE-6141 branch from 0dfdb15 to 0c84141 Compare August 22, 2024 10:56

skorotkov force-pushed the IGNITE-6141 branch from aaa1189 to b863e17 Compare August 30, 2024 07:15

skorotkov marked this pull request as ready for review August 30, 2024 09:51

rkondakov and others added 9 commits September 3, 2024 14:24

IGNITE-6141: CLOB implementation and tests

67c2af0

IGNITE-6141: Minor refactoring

7249099

IGNITE-6141: JDBC2 Driver Clob and Blob support implementation

fc837d2

IGNITE-6141: JDBC Thin Driver Clob and Blob support implementation

4e7f3ab

IGNITE-6141 Fix unit tests and code

fbdf597

IGNITE-6141 Implement read for arrays

4988f7b

IGNITE-6141 Fix code smells

815a30a

IGNITE-6141 Fix code style

ffe79ac

IGNITE-6141 Support empty blobs

753ad04

skorotkov force-pushed the IGNITE-6141 branch from 7f4a9b6 to 753ad04 Compare September 3, 2024 07:25

skorotkov changed the title ~~IGNITE-6141 JDBC thin: support BLOB and CLOB types~~ IGNITE-6141 JDBC: support BLOB and CLOB types Sep 3, 2024

skorotkov changed the title ~~IGNITE-6141 JDBC: support BLOB and CLOB types~~ IGNITE-6141 JDBC: add basic support for BLOB and CLOB types Sep 3, 2024

nizhikov reviewed Sep 4, 2024

View reviewed changes

skorotkov added 3 commits September 4, 2024 20:31

IGNITE-6141 Use assertThrows in tests

98f064d

IGNITE-6141 Use zero-based indexes in internal implementations

f19fa46

IGNITE-6141 Include all parameters to toStirng

c4505f0

nizhikov reviewed Sep 10, 2024

View reviewed changes

nizhikov approved these changes Sep 10, 2024

View reviewed changes

IGNITE-23113 Fix code style and reduce type casts

fc09a40

nizhikov reviewed Sep 10, 2024

View reviewed changes

skorotkov added 3 commits September 10, 2024 21:40

IGNITE-6141 Reduce CPU cycles needed for stream unit test

41d3506

IGNITE-6141 Fix asserts in unit tests

467fa28

IGNITE-6141 Fix sonar warnings

1b0da8d

nizhikov merged commit 95afef0 into apache:master Sep 11, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IGNITE-6141 JDBC: add basic support for BLOB and CLOB types #11492

IGNITE-6141 JDBC: add basic support for BLOB and CLOB types #11492

skorotkov commented Aug 22, 2024 •

edited

Loading

nizhikov Sep 4, 2024

skorotkov Sep 4, 2024

nizhikov Sep 4, 2024

skorotkov Sep 4, 2024

skorotkov Sep 6, 2024

nizhikov Sep 4, 2024

skorotkov Sep 4, 2024

nizhikov Sep 4, 2024

nizhikov Sep 4, 2024

nizhikov Sep 4, 2024

skorotkov Sep 6, 2024 •

edited

Loading

nizhikov Sep 4, 2024

skorotkov Sep 6, 2024

nizhikov Sep 10, 2024

nizhikov Sep 10, 2024

nizhikov Sep 10, 2024

nizhikov Sep 10, 2024

skorotkov Sep 10, 2024

nizhikov Sep 10, 2024

nizhikov Sep 10, 2024

nizhikov Sep 10, 2024

nizhikov Sep 10, 2024

nizhikov Sep 10, 2024

nizhikov Sep 10, 2024

nizhikov Sep 10, 2024 •

edited

Loading

nizhikov Sep 10, 2024

nizhikov Sep 10, 2024

nizhikov Sep 10, 2024

nizhikov Sep 10, 2024

sonarqubecloud bot commented Sep 10, 2024

IGNITE-6141 JDBC: add basic support for BLOB and CLOB types #11492

IGNITE-6141 JDBC: add basic support for BLOB and CLOB types #11492

Conversation

skorotkov commented Aug 22, 2024 • edited Loading

The Contribution Checklist

Notes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skorotkov Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nizhikov Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Sep 10, 2024

Quality Gate passed

skorotkov commented Aug 22, 2024 •

edited

Loading

skorotkov Sep 6, 2024 •

edited

Loading

nizhikov Sep 10, 2024 •

edited

Loading