Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fix): add foreground process for hubble-1.0.0 image #565

Merged
merged 11 commits into from
Dec 24, 2023

Conversation

aroundabout
Copy link
Contributor

Purpose of the PR

  • in hubble-1.0.0, there is no foreground process, add the tail process

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 23, 2023
@imbajin
Copy link
Member

imbajin commented Dec 24, 2023

Also fix the hubble CI error~

@dosu-bot what could u do for us?

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 24, 2023
@devstein
Copy link

Hey @imbajin Dosu can't be summoned on PRs at the moment

Out of curiosity, what was the behavior you were expecting? It's helpful to know for future features

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (docker-1.0.0@3f0a323). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             docker-1.0.0     #565   +/-   ##
===============================================
  Coverage                ?   62.55%           
  Complexity              ?     1866           
===============================================
  Files                   ?      260           
  Lines                   ?     9412           
  Branches                ?      872           
===============================================
  Hits                    ?     5888           
  Misses                  ?     3142           
  Partials                ?      382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin merged commit cd05eea into apache:docker-1.0.0 Dec 24, 2023
@imbajin
Copy link
Member

imbajin commented Dec 24, 2023

Hey @imbajin Dosu can't be summoned on PRs at the moment

Out of curiosity, what was the behavior you were expecting? It's helpful to know for future features

Oh, I just test the function of it...

Because it also doesn't appear in issues (refer #563)
So I wanted to test when & how it works... (BTW, I got your mail just now & have a good understanding of its context)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants