kie-issues#970: Test Scenario Editor: Integrate the @kie-tools/scesim-editor component with the DMN Marshaller
#2887
Conversation
# Conflicts: # packages/scesim-editor/src/creation/TestScenarioCreationPanel.tsx # packages/scesim-editor/stories/dev/DevWebApp.stories.tsx # packages/scesim-editor/stories/scesimEditorStoriesWrapper.tsx # repo/graph.json
yesamer
added
pr: DO NOT MERGE
|
🥳 🍾 🚀 |
packages/scesim-editor/src/drawer/TestScenarioDrawerSettingsPanel.tsx
Outdated
Show resolved
Hide resolved
packages/scesim-editor/src/drawer/TestScenarioDrawerSettingsPanel.tsx
Outdated
Show resolved
Hide resolved
packages/scesim-editor/src/drawer/TestScenarioDrawerSettingsPanel.tsx
Outdated
Show resolved
Hide resolved
packages/scesim-editor/src/creation/TestScenarioCreationPanel.tsx
Outdated
Show resolved
Hide resolved
| if (callBackError) { | ||
| throw callBackError; | ||
| } | ||
| }, [callBackError]); |
There was a problem hiding this comment.
If we're letting error propagete, why do we need the callBackError state? Why not let them explode when they happen? Mapping errors as state is usually for a try/catch-like mechanism, when we want the screen to show a different UI for when errors occur.
There was a problem hiding this comment.
Good observation, so it's enough to rethrow the error inside the catch block, right?
There was a problem hiding this comment.
What try/catch block? Sorry it seems there are multiple ones. If an error happens and we do something on the screen to "treat it", I think we shouldn't re-throw it. Now, if it's really an "end of the world" type of error, I think we should just throw and let the first ErrorBoundary catch it.
There was a problem hiding this comment.
Mapping errors as state is usually for a try/catch-like mechanism, when we want the screen to show a different UI for when errors occur.
I guess that is the case. The error is retrieved and set in the state in the catch blocks at lines 92 and 124.
Without that useEffect(), the error is NOT propagated to the error boundary, at least with the tests I did.
packages/scesim-editor/src/creation/TestScenarioCreationPanel.tsx
Outdated
Show resolved
Hide resolved
|
Postponing my review after code changes required by @tiagobento are in. |
|
@jomarko @tiagobento Hi, can you please give priority to this PR review? It would be great to have this merged EOD. Thank you |
|
Expediting my approval here by your request @yesamer. We can address any outstanding issues on separate PRs. Thanks! |
Closes apache/incubator-kie-issues#970
This PR integrates the new Scesim Editor with the DMN Marshaller, making it possible to retrieve required information from an External DMN Model.
To whoever will review and test this PR, please consider some KI have already reported here
In addition, some use cases are still not fully implemented (eg. collections, expressions, nested data objects)
Those will be managed with apache/incubator-kie-issues#1514
Some examples:
Opening an existing Scesim file:
Screen.Recording.2025-02-05.at.15.24.17.mov
Creating a new DMN-based Scesim file with auto-population
Screen.Recording.2025-02-05.at.15.17.19.mov
Creating a new DMN-based Scesim file without auto-population
Screen.Recording.2025-02-05.at.15.19.16.mov
Opening an existing DMN-based Scesim file with the referenced DMN file removed
Screen.Recording.2025-02-05.at.15.27.45.mov
Opening an existing DMN-based Scesim file with the referenced DMN file moved to another location
Screen.Recording.2025-02-05.at.16.43.28.mov
Blocked by #2866. Required to update the tests.