kie-issues#1808: New Test Scenario and DMN Editors in built project load DMN models twice #2931
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomarko
reviewed
Feb 25, 2025
There was a problem hiding this comment.
I am sorr, I am out of time to do a manual review I usually do.
If you confirm these scenarios are fixed I just trust your changes, code looks ok to me.
Using a project where mvn clean install was done:
- DMN Editor: including other model (DMN and PMML) does not list duplicates
- SCESIM Editor: Creating new file does not list duplicates
Then feel free to proceed with merge.
|
@jomarko I added a screenshot as a piece of evidence for the fix. I guess it's fine to skip the manual testing. If the code is ok, can you please approve the PR? Thank you. |
jomarko
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1808
All resources in the
target/classesdirectory should be filtered out