feature: add saga persistence layer #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjlgod
reviewed
Jan 29, 2024
xjlgod
reviewed
Jan 30, 2024
| db *sql.DB | ||
| } | ||
|
|
||
| func SelectOne[T any](db *sql.DB, sql string, fn ScanRows[T], args ...any) (T, error) { |
There was a problem hiding this comment.
Generics are also used here, need to remove them?
There was a problem hiding this comment.
I suggest we can keep this generic function. It maps the Rows to arbitrary type T, which I think it is a good abstract in my POV. If not using generics, we can only change the return type to interface{}, and use type conversion db.SelectOne(...).(StateMachineInstance) at the invocation.
wt-better
approved these changes
Feb 2, 2024
added 2 commits
February 2, 2024 12:06
…a-db # Conflicts: # pkg/saga/statemachine/constant/contant.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR involves the storage aspect of the state machine. The primary focus will be on creating SQL templates, with reference to the seata-engine-store module.
Which issue(s) this PR fixes:
Fixes #638
Special notes for your reviewer:
UTs are under the same directory as sources