Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grpc invoker in saga mode #668

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

xjlgod
Copy link
Contributor

@xjlgod xjlgod commented Feb 22, 2024

What this PR does:
This PR involves the grpc task and invoker of the state machine. The primary focus will be on calling grpc client invoking and retrying by service task.

Which issue(s) this PR fixes:

Fixes #639

Special notes for your reviewer:
UTs are under the same directory as sources, and it including an e2e test.

Copy link
Member

@ptyin ptyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greate job at functionalities and tests, and yet there are some minor problems

pkg/saga/statemachine/engine/invoker/grpc_invoker_test.go Outdated Show resolved Hide resolved
pkg/saga/statemachine/engine/invoker/grpc_invoker.go Outdated Show resolved Hide resolved
testdata/saga/engine/invoker/grpc/product.proto Outdated Show resolved Hide resolved
@ptyin
Copy link
Member

ptyin commented Feb 27, 2024

LGTM

@ptyin ptyin merged commit 90a8721 into apache:feature/saga Feb 27, 2024
1 check passed
@ptyin ptyin linked an issue Mar 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service invocation (RPC) in both seata-go and seata Saga
2 participants