Skip to content

Conversation

@everfid-ever
Copy link
Contributor

@everfid-ever everfid-ever commented Oct 30, 2025

What this PR does:
Improves test coverage for the errors package from 0% to 100% by adding comprehensive unit tests for SeataError and New() function.

Which issue(s) this PR fixes:
Fixes #960

Does this PR introduce a user-facing change?:

NONE

@github-actions github-actions bot added coding bug Something isn't working labels Oct 30, 2025
@everfid-ever everfid-ever changed the title test: improve error package test test: improve test coverage for pkg/util/errors Nov 4, 2025
@Code-Fight Code-Fight removed the bug Something isn't working label Nov 5, 2025
@github-actions github-actions bot added the bug Something isn't working label Nov 5, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.39%. Comparing base (4420143) to head (51332f0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
+ Coverage   46.33%   46.39%   +0.05%     
==========================================
  Files         195      195              
  Lines       11887    11887              
==========================================
+ Hits         5508     5515       +7     
+ Misses       5943     5936       -7     
  Partials      436      436              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 2.1.0 milestone Nov 6, 2025
@slievrly slievrly merged commit 1de80ee into apache:master Nov 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working coding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve test coverage for pkg/util/errors

4 participants