Skip to content

Conversation

@everfid-ever
Copy link
Contributor

What this PR does:
Add additional unit tests for the pkg/util/log package to improve test coverage and validate error-handling scenarios.

Which issue(s) this PR fixes:
Fixes #961

Special notes for your reviewer:

  • Added tests for zap initialization failures, fatal log behavior, and concurrent writes.
  • Current coverage increased from 0% - 73.6%.
  • No logic changes to production code.

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.59%. Comparing base (4420143) to head (dc1cbc8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
+ Coverage   46.33%   46.59%   +0.25%     
==========================================
  Files         195      196       +1     
  Lines       11887    12006     +119     
==========================================
+ Hits         5508     5594      +86     
- Misses       5943     5972      +29     
- Partials      436      440       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 2.1.0 milestone Nov 6, 2025
@slievrly slievrly merged commit 0747d09 into apache:master Nov 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve test coverage for pkg/util/log

3 participants