test: improve test coverage for pkg/integration/dubbo #968
+283
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #968 +/- ##
==========================================
+ Coverage 48.49% 48.72% +0.22%
==========================================
Files 199 199
Lines 12329 12329
==========================================
+ Hits 5979 6007 +28
+ Misses 5880 5852 -28
Partials 470 470 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit test coverage for the dubboTransactionFilter component in the Dubbo integration. The tests validate XID (transaction ID) propagation between contexts and RPC attachments for both dubbo-go and dubbo-java formats.
- Adds mock implementations of
protocol.Invocation,protocol.Invoker, andprotocol.Resultinterfaces - Implements tests for the
Invokemethod covering various XID scenarios - Adds tests for helper methods
getRpcXid,getDubboGoRpcXid, andgetDubboJavaRpcXid - Tests the
InitSeataDubboinitialization function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #949