test: add some test #979
Open
test: add some test #979
+2,839
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive unit tests for all SQL query builder functions in tcc_fence_store_sql.go to achieve 100% test coverage. Tests cover: - All 7 public SQL generation functions - Multiple table name scenarios (standard, custom, schema-qualified, empty) - Parameter placeholder handling for batch operations - SQL structure validation and placeholder counting - Status enum value verification - SQL injection protection through prepared statements - Edge cases and error conditions Fixes apache#958
Add comprehensive unit tests for tcc_fence_wrapper_handler.go to achieve 84.5% test coverage (exceeding the 70% target). Tests cover: - Singleton fence handler initialization - Clean period configuration - PrepareFence with success, duplicate entry, and error scenarios - CommitFence with various fence status scenarios - RollbackFence with various fence status scenarios - Private helper methods (insertTCCFenceLog, updateFenceStatus) - Batch delete operations - Channel-based log cleanup operations - InitLogCleanChannel and DestroyLogCleanChannel - Concurrent cleanup goroutines Fixes apache#957
github-actions
bot
added
documentation
Add sync.RWMutex to mockTCCFenceStore to protect concurrent access to mock functions from multiple goroutines. This fixes race conditions detected by go test -race. The race detector identified concurrent reads/writes to the mock's function fields when goroutines in traversalCleanChannel tests accessed the mock simultaneously.
github-actions
bot
added
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #979 +/- ##
==========================================
+ Coverage 46.33% 46.85% +0.51%
==========================================
Files 195 197 +2
Lines 11887 12044 +157
==========================================
+ Hits 5508 5643 +135
- Misses 5943 5961 +18
- Partials 436 440 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@WangzJi Pls format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #958
Fixes #957
Fixes #956
Fixes #955
Special notes for your reviewer:
Does this PR introduce a user-facing change?: