KAFKA-18634: Fix ELR metadata version issues #18680
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalvinConfluent
commented
Jan 23, 2025
ahuang98
reviewed
Jan 31, 2025
There was a problem hiding this comment.
Just for my understanding, how is ELRV_1 currently enabled? Is it currently only possible via the storage tool feature argument?
also noticed
EligibleLeaderReplicasVersion.isEligibleLeaderReplicasFeatureEnabeld()has a typo and seems to be dead codeEligibleLeaderReplicasVersion.fromFeatureLevel(short version)also seems unused
| @@ -113,15 +113,15 @@ public enum MetadataVersion { | |||
| // Bootstrap metadata version for version 1 of the GroupVersion feature (KIP-848). | |||
| IBP_4_0_IV0(22, "4.0", "IV0", false), | |||
|
|
|||
| // Add ELR related supports (KIP-966). | |||
There was a problem hiding this comment.
Jira mentioned we should include what metadata records changed, what do you think?
| @@ -30,6 +31,7 @@ public final class ImageWriterOptions { | |||
| public static class Builder { | |||
| private MetadataVersion metadataVersion; | |||
| private MetadataVersion requestedMetadataVersion; | |||
| private Map<String, Short> finalizedFeatures; | |||
There was a problem hiding this comment.
can we derive the MetadataVersion from the finalizedFeatures map? or alternatively just store EligibleLeaderReplicasVersion instead of the whole features map
cmccabe
reviewed
Feb 4, 2025
metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java
Outdated
Show resolved
Hide resolved
cmccabe
reviewed
Feb 4, 2025
| @@ -387,7 +387,7 @@ public ApiMessageAndVersion toRecord(Uuid topicId, int partitionId, ImageWriterO | |||
| setLeaderRecoveryState(leaderRecoveryState.value()). | |||
| setLeaderEpoch(leaderEpoch). | |||
| setPartitionEpoch(partitionEpoch); | |||
| if (options.metadataVersion().isElrSupported()) { | |||
| if (options.isEligibleLeaderReplicasEnabled()) { | |||
There was a problem hiding this comment.
In the case where metadata is lost, we need to use the lossHandler to print a warning message.
There was a problem hiding this comment.
I assume it is not relevant to this PR but I add the metadata check here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the places that should not use MV to determine ELR is enabled
Mark 4.0IV1 stable.
https://issues.apache.org/jira/browse/KAFKA-18634