KAFKA-18522: Slice records for share fetch #18804
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- gradle/spotbugs-exclude.xml: Language not supported
- core/src/test/java/kafka/server/share/ShareFetchUtilsTest.java: Evaluated as low risk
- core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: Evaluated as low risk
- core/src/test/java/kafka/server/share/DelayedShareFetchTest.java: Evaluated as low risk
Comments suppressed due to low confidence (3)
core/src/test/java/kafka/server/share/SharePartitionTest.java:5898
- Consider overloading the fetchAcquiredRecords method instead of adding a boolean flag for subsetAcquired.
private List<AcquiredRecords> fetchAcquiredRecords(
core/src/test/java/kafka/server/share/SharePartitionTest.java:5914
- Ensure that the memoryRecordsBuilder method from ShareFetchTestUtils is used consistently across all tests.
return memoryRecordsBuilder(numOfRecords, startOffset).build();
server/src/main/java/org/apache/kafka/server/share/fetch/ShareAcquiredRecords.java:45
- Ensure that the subsetAcquired flag is properly tested to verify the slicing logic works correctly when this flag is true or false.
private final boolean subsetAcquired;
server/src/main/java/org/apache/kafka/server/share/fetch/ShareAcquiredRecords.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- gradle/spotbugs-exclude.xml: Language not supported
- core/src/main/java/kafka/server/share/ShareFetchUtils.java: Evaluated as low risk
- core/src/main/java/kafka/server/share/SharePartition.java: Evaluated as low risk
- core/src/test/java/kafka/server/share/DelayedShareFetchTest.java: Evaluated as low risk
server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTestUtils.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR handles slicing of fetched records based on acquire response for share fetch. There could be additional bytes fetched from log but acquired offsets can be a subset, typically with
max fetch recordsconfiguration. Rather sending additional bytes of fetched data to client we should slice the file and wire only needed batches.Note: If the acquired offsets are within a batch then we need to send the entire batch within the file record. Hence rather checking for inidividual batches, PR finds the first and last acquired offset, and trims the file for all batches between (inclusive) these two offsets.