Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCHANGES-434] @Component --> @Inject #44

Merged
merged 9 commits into from
Nov 22, 2024
Merged

[MCHANGES-434] @Component --> @Inject #44

merged 9 commits into from
Nov 22, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Nov 22, 2024

No description provided.

@elharo elharo marked this pull request as ready for review November 22, 2024 10:05
@elharo elharo changed the title @Component --> @Inject [MCHANGES-434] @Component --> @Inject Nov 22, 2024
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove plugin execution plexus-component-metadata

@slawekjaranowski
Copy link
Member

If we use @ and something in commits, descriptions ... GitHub create a link to such account.

We should escape such words by ` , eg

`@Inject`

@elharo
Copy link
Contributor Author

elharo commented Nov 22, 2024

I don't see any such links. I think it only autolinks in textboxes like this one, not everywhere

@elharo
Copy link
Contributor Author

elharo commented Nov 22, 2024

I don't see any such links. I think it only autolinks in textboxes like this one, not everywhere

OK I do see one such link. However I still think we shouldn't change the general git commit message based on how Github will interpret it.

@elharo elharo merged commit 9ca73d0 into master Nov 22, 2024
51 checks passed
@elharo elharo deleted the guice branch November 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants