Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCHANGES-439] Deprecate useJql #56

Merged
merged 4 commits into from
Nov 23, 2024
Merged

[MCHANGES-439] Deprecate useJql #56

merged 4 commits into from
Nov 23, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Nov 22, 2024

No description provided.

@elharo elharo marked this pull request as ready for review November 22, 2024 19:51
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cen remove such preparing next major
and issue - MCHANGES-439?

@elharo elharo changed the title [MDEP-439] Deprecate useJql [MCHANGES-439] Deprecate useJql Nov 22, 2024
@slawekjaranowski
Copy link
Member

@elharo
Copy link
Contributor Author

elharo commented Nov 23, 2024

good point on docs; done

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think that we can simply remove, even more that is not used in code.

Simply users will have a warning that use not existing parameter,
with deprecated they will have warning abut deprecation,
so will be similar from user perspective.

@elharo
Copy link
Contributor Author

elharo commented Nov 23, 2024

What specifically do you want to remove? We shouldn't take out the parameter without a deprecation cycle because it likely still exists in some folks' poms.

@slawekjaranowski
Copy link
Member

What specifically do you want to remove? We shouldn't take out the parameter without a deprecation cycle because it likely still exists in some folks' poms.

Yes we should do a deprecate cycle for so minor versions in major version I hope we can simply remove parameter. But as you wish it can be deprecated.

@elharo elharo merged commit 41fd137 into master Nov 23, 2024
51 checks passed
@elharo elharo deleted the loop branch November 23, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants