-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Add Database Connection dialog for SQLite, DuckDB, BigQuery, and Snowflake #8189
Open
eirikbakke
wants to merge
3
commits into
apache:master
Choose a base branch
from
eirikbakke:pr-dbconnfile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6bc27e1
to
7ffd540
Compare
mbien
reviewed
Jan 24, 2025
7c057f6
to
0b21eb1
Compare
I added another commit which recognizes Snowflake JDBC URLs, just since we're already making enhancements to this piece of code. |
mbien
reviewed
Jan 31, 2025
0e58cc0
to
c4705c3
Compare
I squashed the previous review edits, and also added a separate commit which recognizes Google BigQuery JDBC URLs. |
0b872b8
to
3894882
Compare
…SQLite and DuckDB URL templates. Also validate the selected file in the SQLite and DuckDB cases. Add a logging statement for one case involving JDBC connection errors that extend from Error rather than Exception (such as NoClassDefFoundError originating from a JDBC driver).
…ver and JDBC URLs.
3894882
to
b8a0fc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:dev-build
[ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page)
FormDesigner
GUI builder, also known as Matisse
UI
User Interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Add Database Connection" dialog supports various kinds of database-specific connection fields (host, port, database name etc.) These are automatically substituted into the JDBC driver specific JDBC URL.
This PR adds support for a "File" field, which will be shown if the user is using the JDBC drivers for SQLite or DuckDB. There is a "Browse" button that can be used to pick the file from a file browser. Furthermore, the username and password fields are hidden for these drivers, which are known not to require this kind of authentication.
For SQLite and DuckDB, there's a warning if the selected file is not of the right kind. (Useful because SQLite files do not have any kind of standardized file extension.)
For comparison, this is what the Add Database Connection dialog looked like before, for SQLite:
(There are some proprietary JDBC drivers for SQLite that do allow a password to be used for encryption, but in this rare case the user could use a connection property to pass this information instead.)