Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nshlib: typo fixed in Kconfig #3019

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

royfengsss
Copy link
Contributor

@royfengsss royfengsss commented Mar 5, 2025

Summary

In nshlib/Kconfig:509:
NSH_DISABLE_NSFMOUNT should be NSH_DISABLE_NFSMOUNT

Impact

Typo fixed. Without this fix, the function "Disable nfsmount" in nsh would not work,
as the code is controlled by CONFIG_NSH_DISABLE_NFSMOUNT

Testing

Test on sim:nsh

  1. enabled NFS function from menuconfig
  2. build and enter nsh shell
  3. use help to check available command
$ ./nuttx 

NuttShell (NSH)
nsh> help
help usage:  help [-v] [<cmd>]

    .           cmp         fdinfo      ls          printf      true        
    [           dirname     free        mkdir       ps          truncate    
    ?           dd          help        mkfatfs     pwd         uname       
    alias       df          hexdump     mkfifo      readlink    umount      
    unalias     dmesg       ifconfig    mkrd        rm          unset       
    arp         echo        ifdown      mount       rmdir       uptime      
    basename    env         ifup        mv          set         usleep      
    break       exec        kill        nfsmount    sleep       watch       
    cat         exit        pkill       pidof       source      xd          
    cd          expr        losetup     poweroff    test        wait        
    cp          false       ln          quit        time        

Builtin Apps:
    dumpstack    gpio         nsh          sh           
    gcov         hello        ostest       

We can see nfsmount is there.

  1. Select "Disable nfsmount" option in menuconfig, then build and check in nsh:
$ ./nuttx 

NuttShell (NSH)
nsh> help
help usage:  help [-v] [<cmd>]

    .           cmp         fdinfo      ls          ps          truncate    
    [           dirname     free        mkdir       pwd         uname       
    ?           dd          help        mkfatfs     readlink    umount      
    alias       df          hexdump     mkfifo      rm          unset       
    unalias     dmesg       ifconfig    mkrd        rmdir       uptime      
    arp         echo        ifdown      mount       set         usleep      
    basename    env         ifup        mv          sleep       watch       
    break       exec        kill        pidof       source      xd          
    cat         exit        pkill       poweroff    test        wait        
    cd          expr        losetup     quit        time        
    cp          false       ln          printf      true        

Builtin Apps:
    dumpstack    gpio         nsh          sh           
    gcov         hello        ostest       
nsh> 

We can see the nfsmount has been disabled.

`NSH_DISABLE_NFSMOUNT` should be `NSH_DISABLE_NFSMOUNT`

Signed-off-by: Roy Feng <[email protected]>
Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @royfengsss :-)

Quick grep of the typo revealed one location in the documentation to be updated too in the nuttx.git repo, could you also provide PR over there @royfengsss ? :-)

% cd nuttx-apps.git
% grep -r NSH_DISABLE_NSFMOUNT *
nshlib/Kconfig:config NSH_DISABLE_NSFMOUNT

% grep -r NSH_DISABLE_NSFMOUNT ../nuttx.git/*
../nuttx.git/Documentation/platforms/arm/lpc31xx/boards/olimex-lpc-h3131/README.txt:          CONFIG_NSH_DISABLE_NSFMOUNT=y

@royfengsss
Copy link
Contributor Author

Hi @cederom

apache/nuttx#15947 has been submitted.

@cederom
Copy link
Contributor

cederom commented Mar 6, 2025

@royfengsss: Hi @cederom
apache/nuttx#15947 has been submitted.

Perfect! Thank you @royfengsss :-) Lets wait for more reviews and we will merge both PRs :-)

@xiaoxiang781216 xiaoxiang781216 merged commit cc33924 into apache:master Mar 24, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants