modbus: add an option to disable log #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce new configuration option that allow disable all logging functionality for FreeModBus. This option is useful for small systems when we don't use any logging features. Signed-off-by: raiden00pl <[email protected]>
|
nxstyle failure is expected because freemodbus is not compatible with NuttX coding style |
cederom
approved these changes
Mar 22, 2025
There was a problem hiding this comment.
Thank you @raiden00pl :-) Yup camel case is ModBus implementation :-)
lupyuen
approved these changes
Mar 23, 2025
anchao
approved these changes
Mar 23, 2025
acassis
approved these changes
Mar 24, 2025
|
Why close not merge @raiden00pl ?? :D |
|
oops, I accidentally deleted an unmerged branch :P restored now |
|
Will merge when CI finished just to keep things clean :-) Lint fail comes from FreeModBusMixedCaseImplementation :-) |
|
@jerpelea backporting to 12.9? :-) |
sadly no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce new configuration option that allow disable all logging functionality for FreeModBus. This option is useful for small systems when we don't use any logging features.
Impact
fix broken compilation when FILE_STREAM is disabled
Testing
local modbus RTU configuration with file streams disabled