Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1686: Adjust GH CI config to build with Java 23 and 24-ea #733

Closed
wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Dec 27, 2024

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.


update workflow to support 23 rather than 23-ea

@mawiesne
Copy link
Contributor

@chenrui333 Thx for the suggested PR.

Could you - instead of removing the experimental 23-ea section - bring it to "24-ea"? We always try to check the upcoming "..-ea" in advance. The addition of the (intermediate) version 23 to the list of stable versions is okay (my pov).

Just update and force push. Once adjusted, I'll open a Jira (required at OpenNLP).

@mawiesne mawiesne changed the title ci: support java 23 (as java 23 already ga) OPENNLP-1686: Adjust GH CI config to build with Java 23 and 24-ea Dec 27, 2024
@mawiesne mawiesne self-requested a review December 27, 2024 20:05
@mawiesne mawiesne marked this pull request as draft December 27, 2024 20:05
@mawiesne
Copy link
Contributor

Just update and force push. Once adjusted, I'll open a Jira (required at OpenNLP).

See: OPENNLP-1686

@rzo1
Copy link
Contributor

rzo1 commented Jan 5, 2025

@chenrui333 Thx for the suggested PR.

Could you - instead of removing the experimental 23-ea section - bring it to "24-ea"? We always try to check the upcoming "..-ea" in advance. The addition of the (intermediate) version 23 to the list of stable versions is okay (my pov).

Just update and force push. Once adjusted, I'll open a Jira (required at OpenNLP).

Since we are planning a patch release this week, I have updated the "ea" part to 24 in #735

@rzo1 rzo1 closed this Jan 6, 2025
@rzo1
Copy link
Contributor

rzo1 commented Jan 6, 2025

Thanks @chenrui333 - we are now building with 24-ea

@chenrui333
Copy link
Contributor Author

yeah, sounds good, thanks folks! 👍

@chenrui333 chenrui333 deleted the support-java-23 branch January 10, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants