Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1848: PrintData tool add parameter description #2126

Closed
wants to merge 1 commit into from

Conversation

cxzl25
Copy link
Contributor

@cxzl25 cxzl25 commented Feb 7, 2025

What changes were proposed in this pull request?

java -jar orc-tools-2.2.0-SNAPSHOT-uber.jar data -h
usage: java -jar orc-tools-*.jar data <orc file>*
 -h,--help            Provide help
 -n,--lines <LINES>   Sets lines of data to be printed

Why are the changes needed?

java -jar orc-tools-2.1.0-uber.jar data -h
usage: java -jar orc-tools-*.jar data <orc file>*
 -h,--help            Provide help
 -n,--lines <LINES>

How was this patch tested?

local test

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the JAVA label Feb 7, 2025
@dongjoon-hyun dongjoon-hyun added this to the 2.1.1 milestone Feb 11, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @cxzl25 .
Merged to main/branch-2.1.

dongjoon-hyun pushed a commit that referenced this pull request Feb 11, 2025
### What changes were proposed in this pull request?
```bash
java -jar orc-tools-2.2.0-SNAPSHOT-uber.jar data -h
usage: java -jar orc-tools-*.jar data <orc file>*
 -h,--help            Provide help
 -n,--lines <LINES>   Sets lines of data to be printed
```

### Why are the changes needed?
```bash
java -jar orc-tools-2.1.0-uber.jar data -h
usage: java -jar orc-tools-*.jar data <orc file>*
 -h,--help            Provide help
 -n,--lines <LINES>
```

### How was this patch tested?
local test

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #2126 from cxzl25/ORC-1848.

Authored-by: sychen <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 2aec4fb)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants