Skip to content

[flink] fix compact_database parameter mode default value#6935

Closed
sd4324530 wants to merge 3 commits into
apache:masterfrom
sd4324530:issue-6934
Closed

[flink] fix compact_database parameter mode default value#6935
sd4324530 wants to merge 3 commits into
apache:masterfrom
sd4324530:issue-6934

Conversation

@sd4324530

Copy link
Copy Markdown
Contributor

Purpose

Linked issue: close #6934
fix compact_database parameter mode default value

Tests

API and Format

Documentation

@sd4324530 sd4324530 closed this Jan 1, 2026
@sd4324530 sd4324530 reopened this Jan 1, 2026
@sd4324530 sd4324530 closed this Jan 2, 2026
@sd4324530 sd4324530 reopened this Jan 2, 2026
@sd4324530 sd4324530 force-pushed the issue-6934 branch 3 times, most recently from 25633be to fbd4a69 Compare January 5, 2026 05:58
@sd4324530

Copy link
Copy Markdown
Contributor Author

@JingsongLi
I just fixed the default value of the 'mode' parameter, these failed checks. I don't understand why.
Please take a look.

@sd4324530

Copy link
Copy Markdown
Contributor Author

@JingsongLi
All checks have passed.
Could you please take a look?

@JingsongLi JingsongLi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean bug fix. The change makes sense - changing the default compact_database mode from DIVIDED to COMBINED.

A few notes:

  1. Breaking change: This changes the default behavior. Users who relied on the implicit DIVIDED default will now get COMBINED behavior unless they explicitly specify --mode divided. This should be documented in release notes.

  2. Test update: Good that the test is updated to explicitly pass --mode divided where DIVIDED behavior is expected, rather than relying on the default.

  3. Linked issue #6934: The fix aligns with the documented default in the documentation/user-facing docs.

LGTM with the caveat that this is technically a behavior change and should be called out in release notes.

sd4324530 added 2 commits May 24, 2026 17:40
Signed-off-by: peiyu <125331682@qq.com>
Signed-off-by: peiyu <125331682@qq.com>
Signed-off-by: Pei Yu <125331682@qq.com>
@JingsongLi JingsongLi closed this May 27, 2026
@JingsongLi JingsongLi reopened this May 27, 2026
@JingsongLi

Copy link
Copy Markdown
Contributor

re-trigger tests

@JingsongLi

Copy link
Copy Markdown
Contributor

This will cause compatibility issues, and we need to update the documentation. If you're willing, you can submit another PR for the document.

@JingsongLi JingsongLi closed this Jun 9, 2026
@sd4324530 sd4324530 deleted the issue-6934 branch June 25, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] compact_database parameter mode default value is wrong

2 participants