[flink] fix compact_database parameter mode default value#6935
[flink] fix compact_database parameter mode default value#6935sd4324530 wants to merge 3 commits into
Conversation
25633be to
fbd4a69
Compare
|
@JingsongLi |
|
@JingsongLi |
aeea1b4 to
ec52800
Compare
8a5d099 to
bab7dd8
Compare
JingsongLi
left a comment
There was a problem hiding this comment.
Clean bug fix. The change makes sense - changing the default compact_database mode from DIVIDED to COMBINED.
A few notes:
-
Breaking change: This changes the default behavior. Users who relied on the implicit DIVIDED default will now get COMBINED behavior unless they explicitly specify
--mode divided. This should be documented in release notes. -
Test update: Good that the test is updated to explicitly pass
--mode dividedwhere DIVIDED behavior is expected, rather than relying on the default. -
Linked issue #6934: The fix aligns with the documented default in the documentation/user-facing docs.
LGTM with the caveat that this is technically a behavior change and should be called out in release notes.
Signed-off-by: peiyu <125331682@qq.com>
Signed-off-by: peiyu <125331682@qq.com>
Signed-off-by: Pei Yu <125331682@qq.com>
|
re-trigger tests |
|
This will cause compatibility issues, and we need to update the documentation. If you're willing, you can submit another PR for the document. |
Purpose
Linked issue: close #6934
fix compact_database parameter mode default value
Tests
API and Format
Documentation