Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mention the faster code fmt approach #1022

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Conversation

Roiocam
Copy link
Member

@Roiocam Roiocam commented Jan 22, 2024

Motivation

Mention an easy way to format pekko code, which allows you to skip the sbt loading, in specific cases may be vert useful.

Using Scala-Cli

截屏2024-01-23 01 52 46

image

Using sbt

截屏2024-01-23 01 53 02

@pjfanning
Copy link
Contributor

I use scalafmt using coursier CLI - see https://scalameta.org/scalafmt/docs/installation.html#cli

We might generally be better off pointing at that https://scalameta.org/scalafmt/docs/installation.html page generally.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@He-Pin
Copy link
Member

He-Pin commented Jan 22, 2024

Let me add that then.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm to me now.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@mdedetrich
Copy link
Contributor

You can also mention that there is scalafmt-native which has installations for various distributions, see https://scalameta.org/scalafmt/docs/installation.html#native-image

@Roiocam
Copy link
Member Author

Roiocam commented Jan 23, 2024

You can also mention that there is scalafmt-native which has installations for various distributions, see https://scalameta.org/scalafmt/docs/installation.html#native-image

It was mentioned in the shell example.

@mdedetrich
Copy link
Contributor

mdedetrich commented Jan 23, 2024

Running CI, if its good to go ill approve

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, link-validator failure appears to be irrelevant

@He-Pin He-Pin merged commit 7ffcf5b into apache:main Jan 23, 2024
17 of 18 checks passed
@Roiocam Roiocam deleted the scala-cli-fmt branch January 27, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants