chore: Move java 21 code to a dedicated folder and including code sni… #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Jan 22, 2024
docs/src/main/java-jdk-21/docs/actors/classical/OptimizedActorWithJava21.java
Outdated
Show resolved
Hide resolved
|
That's great. So that's how it's done. |
Roiocam
reviewed
Jan 24, 2024
| } | ||
| } | ||
| ``` | ||
| Java 21 |
There was a problem hiding this comment.
Looks great, this is kind of like Tabs feature in docusaurus.
I often use Tabs when writing release notes at work.
I think this is a good example when we add the newest JDk-related features in the future.
|
|
||
| // #pattern-matching | ||
|
|
||
| static class OptimizedActorWithJava21 extends UntypedAbstractActor { |
There was a problem hiding this comment.
should also add there source directory on the build script, as JDK9.scala does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Group code in Java and Java21 tab, and as the origin is under in
@@@ div { .group-java }, so It will not be visible to Scala user too.Continue of #1011