-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Using dependency walking to verify JDK9 Plugin works #1065
Conversation
@mdedetrich Do you have time to review this? It solves #1040 and is simpler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain.
7f34b12
to
b1b4316
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. My only complaint is that we now seem to have multiple JDK9 checks (@He-Pin also wrote one). While there technically isn't a problem with having multiple checks in this case it can be confusing for the readers of the code and I have a slight preference for this variant since its actually checking the root issue and importantly not checking for things that historically hasn't been issues
Should be fine, this is pre-checking and my PR is post-checking, we chatted on WeChat about how to check the jdk9 classes and come up with different solutions. |
b1b4316
to
5aaf2a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, just naming thing.
Signed-off-by: Andy.Chen <[email protected]>
Signed-off-by: Andy.Chen <[email protected]>
Signed-off-by: Andy.Chen <[email protected]>
Motivation
solve #1040
Use dependency walk(inspired by
sbt inspect
) to detect JDK9 plugin works or not.Benefits:
unzip
either.Usage
It is easier to use, with only one command.
Verify It
You can verify this plugin works by using two ways:
sbt jdk9Check
jdk8-only
module(i.e. actor), and then run commandsbt actor/jdk9Check