Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove more reflectiveCall. #1084

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Jan 30, 2024

Motivation:
Remove more reflectiveCall usage from the codebase.
https://docs.scala-lang.org/scala3/guides/migration/incompat-type-inference.html

Result:
Clean code.

Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made sense, LGTM, Thanks.

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin merged commit 5e00e6b into apache:main Jan 30, 2024
18 checks passed
@He-Pin He-Pin deleted the reflectiveCall branch January 30, 2024 15:51
@pjfanning pjfanning added this to the 1.1.0-M1 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants