Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO-NOT-MERGE] chore: bump scala version to 3.4.0-RC1 #878

Closed
wants to merge 1 commit into from

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Dec 25, 2023

Just test how it works with new Scala version

@He-Pin He-Pin marked this pull request as draft December 25, 2023 07:57
@He-Pin
Copy link
Member Author

He-Pin commented Dec 25, 2023

Ha, does catch some errors, Do we need to drop 2.12.x if we want the code compiles with 3.4.x too? @SethTisue ping

@SethTisue
Copy link
Contributor

SethTisue commented Jan 7, 2024

It's normal that 3.4 may throw some warnings that aren't fixable while still cross-compiling to 2.12 (and, in a smaller number of cases, even to 2.13). I would suggest simply silencing the warnings in question (with -Wconf).

However, quite separately from any issues around warnings, it may be that you don't want to upgrade to 3.4 at all, as that would require users to move to 3.4, but 3.4 is not an LTS version of Scala.

Note that Akka itself dropped 2.12 support in akka/akka#32125.

@pjfanning
Copy link
Contributor

Thanks @SethTisue for the insights. I just checked our Maven Central stats and our Scala 2.12 jars seem to be at least as popular as Scala 2.13, with Scala 3 jars trailing (quite a bit). Scala 2.12 jar downloads dominated last month but the Unique IPs stats show higher numbers for Scala 2.13 than for 2.12. Pretty erratic stats overall.

@mdedetrich
Copy link
Contributor

mdedetrich commented Jan 8, 2024

For the reasons that @pjfanning stated, like with JDK 8 we are not going to dropping Scala 2.12 support anytime soon. Aside from the "significant amount of people are still using 2.12" argument, sbt is indirectly making Scala 2.12 the pseudo minimum Scala 2 version.

Its fine if other projects want to drop it, but in our case Scala 2.12 support isn't really causing any significant burdern. Most of it has been abstracted away with our various org.apache.pekko.util.* functions and its one of those things that once set you don't have to worry about it.

Regarding the PR on hand, while I have no problem in people trying Scala 3.4 with Pekko, in my opinion its very premature (and hence kind of a waste of time) because no Pekko module will use Scala 3.4 since due to how Scala 3 works with semver, picking a Scala version effectively creates a floor that transitively forces everyone to use at least that version.

So the only minor Scala version that we would ever move to would be the next LTS which I assume would be a few years out (at least). Even then its likely that we would still stick to Scala 3.3.x because it would take quite a while for the Scala ecosystem to move to the next LTS.

@He-Pin He-Pin closed this Mar 23, 2024
@He-Pin He-Pin deleted the He-Pin-patch-1 branch March 23, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants