Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Sink.exists operator #990

Merged
merged 3 commits into from
Jan 30, 2024
Merged

feat: Add Sink.exists operator #990

merged 3 commits into from
Jan 30, 2024

Conversation

GreyPlane
Copy link
Contributor

@GreyPlane GreyPlane commented Jan 20, 2024 •
edited by He-Pin
Loading

Motivation:
Add the Sink.exists operator.

co-authored with: He-Pin

Result:
Rich operators set and close: #973
image

@laglangyue
Copy link
Contributor

add test for javadsl, add document

@He-Pin
Copy link
Member

He-Pin commented Jan 20, 2024

First:
Thanks and welcome contributions from China user group.

What still missing, the exists.md , the JavaTest, the Demo code, which is needed in the exists.md. and in exists.md, will need an urlencoded for the scaladoc function signature.

For formating, you can try scala-cli fmt , which is fast.

@He-Pin He-Pin added the t:stream Pekko Streams label Jan 20, 2024
@He-Pin He-Pin added this to the 1.1.0 milestone Jan 20, 2024
@GreyPlane
Copy link
Contributor Author

docs was removed for now, in favor to fire another PR for adding Sink-or-Flow category for document.

@He-Pin
Copy link
Member

He-Pin commented Jan 24, 2024

Friendly ping, we are scheduling a 1.1.0-M1 release soon, would you like to work on this this weekend, thanks. @GreyPlane

@He-Pin
Copy link
Member

He-Pin commented Jan 29, 2024

I will take care of it, as I discussed with @GreyPlane.

@He-Pin He-Pin changed the title feat: +Flow.exists & Sink.exists feat: Add Sink.exists operator Jan 29, 2024
@He-Pin He-Pin marked this pull request as draft January 29, 2024 14:47
@He-Pin He-Pin linked an issue Jan 29, 2024 that may be closed by this pull request
Feature request:Add Sink.exists operator #973
Closed
@He-Pin He-Pin marked this pull request as ready for review January 29, 2024 16:30
jxnu-liguobin
jxnu-liguobin approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@jxnu-liguobin jxnu-liguobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

laglangyue
laglangyue reviewed Jan 30, 2024
View reviewed changes
docs/src/main/paradox/stream/operators/Sink/forall.md
@@@
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small issue, seemingly unrelated change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a bland endline here.

@laglangyue
Copy link
Contributor

LGTM, although has an irrelevant issue.

Roiocam
Roiocam approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@He-Pin
Copy link
Member

He-Pin commented Jan 30, 2024

As I have rewritten most of the code, I think we can bring this in, and @GreyPlane Thank you for your time.

@He-Pin He-Pin merged commit abad72d into apache:main Jan 30, 2024
17 of 18 checks passed
@pjfanning pjfanning added the release notes Need to release note label Feb 5, 2024
@pjfanning pjfanning removed the release notes Need to release note label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He-Pin He-Pin He-Pin left review comments

@laglangyue laglangyue laglangyue left review comments

@Roiocam Roiocam Roiocam approved these changes

@jxnu-liguobin jxnu-liguobin jxnu-liguobin approved these changes

@mdedetrich mdedetrich Awaiting requested review from mdedetrich

@pjfanning pjfanning Awaiting requested review from pjfanning

@nvollmar nvollmar Awaiting requested review from nvollmar

Assignees
No one assigned
Labels
t:stream Pekko Streams
Projects
None yet
Milestone
1.1.0-M1
Development

Successfully merging this pull request may close these issues.

Feature request:Add Sink.exists operator
6 participants
@GreyPlane @laglangyue @He-Pin @pjfanning @Roiocam @jxnu-liguobin