Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #63] Support rich initialization modes of RocketMQSource & Fix some bugs #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deemogsw
Copy link
Contributor

@deemogsw deemogsw commented Nov 3, 2022

Support rich initialization modes of RocketMQSource Fix some bugs

@deemogsw deemogsw changed the title [ISSUE #63] [ISSUE #63] Support rich initialization modes of RocketMQSource & Fix some bugs Nov 3, 2022
@deemogsw
Copy link
Contributor Author

deemogsw commented Nov 3, 2022

  • [bug]PartitionDiscoveryIntervalMs can't set to negative
  • [bug]Idle source task can't be released automatic
  • [bug]Offset didn't commit to broker in RockerMQSource in phase of checkpoint
  • [bug]Records can't arrive to sink() in UNBOUNDESS mode
  • [features]Commit offset immediately when checkpoint is disable
  • [features]Support rich initialization modes
  • [features]Metrics with new source
  • [features]Boost for flink-sql-connector

@deemogsw
Copy link
Contributor Author

deemogsw commented Nov 3, 2022

As description in issue #69 ,branch of master has some bugs with pr #46 .So my branch still be dependent on common pull mode.
I will complete the README.md with usage of sql-connector later.
@lizhimins @SteNicholas Can you help me review the code?

@GOODBOY008
Copy link
Member

@deemogsw Thanks for your contributions! Can you rebase to last main branch.

@deemogsw
Copy link
Contributor Author

deemogsw commented Nov 9, 2022

@deemogsw Thanks for your contributions! Can you rebase to last main branch.

Main branch has bug in litepull consumer.I have mentioned in issue #69 .You can also have a try by running the latest cade

@deemogsw deemogsw force-pushed the featureOfRocketMQSource branch from 6ad4430 to 4d312b3 Compare November 13, 2022 12:08
@SteNicholas
Copy link
Member

@deemogsw, could you please resolve the conflicts firstly?

@deemogsw deemogsw force-pushed the featureOfRocketMQSource branch from 4d312b3 to c8dcabe Compare January 17, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants