Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue_31559 MySQL parsing #34703

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

Yash-cor
Copy link
Contributor

@Yash-cor Yash-cor commented Feb 18, 2025

Fixes #31559 .

Changes proposed in this pull request:

No grammar change was required
All the queries that were stated in this were working correctly
Included the test case in xml format as asked in the issue.

Test cases included for MySQL are as follows:

  • NAME_CONST()
  • NOT IN()
  • NOT LIKE
  • NOT REGEXP
  • NOW()
  • NTH_VALUE()
  • NTILE()
  • NULLIF()
  • OCT()
  • OCTET_LENGTH()
  • ORD()
  • PERCENT_RANK()
  • PERIOD_ADD()
  • PERIOD_DIFF()
  • PI()

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@Yash-cor Yash-cor changed the title Issue_31559 MySQL parsing check Issue_31559 MySQL parsing Feb 19, 2025
@strongduanmu strongduanmu added this to the 5.5.3 milestone Feb 19, 2025
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, merged.

@strongduanmu strongduanmu merged commit b4138e6 into apache:master Feb 20, 2025
14 checks passed
@strongduanmu
Copy link
Member

Hi @Yash-cor, can you comment on the issue? I will assign it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the parsing of methods in MySQL
2 participants