SLING-12642 cache privileges and principals in the context of the invoking Jackrabbit Session #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the AclUtil there are many occassions where privileges and principals are resolved over and over again (probably many times the same).
In order to remove the redundant retrieval I added
CachingSesssionWrapper
which is passed instead of the session; by default the wrapped session is used, but the following 2 functionalities are executed in an optimized way by the CachingSessionWrapper:privilegesFromNames
(convert the privilege names into privilege objects)expandPrivilege
( to expand aggregated privileges into the contained privileges)getPrincipal
( to retrieve a principal for a given principal name)All these results are cached within the CachingSessionWrapper. As this object shares the same lifetime as the
session
object itself, and as the results are immutable, it's safe to do so.Note:
getPrincipal
is safe here, as no principals are removed here.For review I advise to review commit by commit.