Initial suport for Tomact9 - Tc9.x #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* From tomcat8-maven-plugin to tomcat9-maven-plugin * From tomcat8-war-runner to tomcat9-war-runner
This was causing the artefact build to fail as it ignored the \ escapes.
Setup the webapp like it would be normally and let Tomcat handle everything. There is one hack to work around a hack in Weld’s WebAppBeanArchiveScanner, which explicitly looks for WEB-INF/classes.
Tomcat is headless. It’s a pain on macOS if this isn’t set.
This fixes a bug where conflicting files in jars would be loaded instead of the same file in the module’s build directory.
Improvements to Tomcat 9 support
Initial support for Tomact9 - tc9.x
Exit if Tomcat fails to start
Exit if Tomcat fails to start
Some aggregator or IT modules do not have any own class files but only tests. This did lead to a startup failure in later tc7 versions Credits to struberg
|
There was some interest to revive the component. So this is a starting point, thanks.
|
|
@rmaucher what about incorporate those changes, tag then for use only up to jdk11 and Java EE 8, release as is? |
|
I could be talked into hitting the merge button. However, there is no way I'll +1 this for a release, it needs a "full" rewrite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution is based on work done by @poolborges, @karlvr and @struberg.
I've just compiled locally!