Skip to content

Fix infinite recursion in get_const_tuple when passed non-tuple input #18766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jikechao wants to merge 7 commits into from
Closed

Fix infinite recursion in get_const_tuple when passed non-tuple input #18766

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
173a542
Handle non-tuple/list input in utils.py
jikechao Feb 12, 2026
d935080
Improve input handling for tuple conversion
jikechao Mar 16, 2026
b1b2876
Improve input handling for in_tuple in utils.py
jikechao Mar 16, 2026
17bba14
Fix condition for tuple and list handling
jikechao Mar 16, 2026
09c11fd
Fix type check for in_tuple to include lists
jikechao Mar 16, 2026
6e7b72e
Improve input type handling in get_const_tuple
jikechao Mar 16, 2026
a61e575
Change TypeError to ValueError in get_const_tuple
jikechao Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/tvm/topi/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ def get_const_tuple(in_tuple):
out_tuple : tuple of int
The output.
"""
if not isinstance(in_tuple, (tuple, list)):
return (in_tuple,)
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change correctly fixes the infinite recursion bug. However, it introduces a backward-incompatible change for te.Tensor inputs. Previously, get_const_tuple(tensor) would effectively process the tensor's shape. With this change, it will return (tensor,). While the previous behavior was undocumented, breaking it might cause issues for existing code.

To maintain backward compatibility for te.Tensor while still fixing the recursion bug for other non-tuple types like PrimExpr, consider handling te.Tensor as a special case. For example, you could modify the logic to be something like:

    if not isinstance(in_tuple, (tuple, list)):
        if isinstance(in_tuple, te.Tensor):
            in_tuple = in_tuple.shape
        else:
            return (in_tuple,)

ret = []
ana = None
for elem in in_tuple:
Expand Down
Loading