Support for the ECDH KeyAgreement method algorithm #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coheigea please note the PR is using the not yet released santuario version |
coheigea
reviewed
Jan 22, 2024
policy/src/main/java/org/apache/wss4j/policy/model/AlgorithmSuite.java
Outdated
Show resolved
Hide resolved
ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecEncryptedKey.java
Outdated
Show resolved
Hide resolved
ws-security-dom/src/main/java/org/apache/wss4j/dom/message/WSSecEncryptedKey.java
Outdated
Show resolved
Hide resolved
ws-security-dom/src/test/java/org/apache/wss4j/dom/message/EncryptionTest.java
Outdated
Show resolved
Hide resolved
ws-security-dom/src/main/java/org/apache/wss4j/dom/processor/EncryptedKeyProcessor.java
Outdated
Show resolved
Hide resolved
coheigea
requested changes
Jan 24, 2024
ws-security-dom/src/test/java/org/apache/wss4j/dom/message/EncryptionTest.java
Show resolved
Hide resolved
ws-security-dom/src/main/java/org/apache/wss4j/dom/processor/EncryptedKeyProcessor.java
Outdated
Show resolved
Hide resolved
ws-security-dom/src/main/java/org/apache/wss4j/dom/processor/EncryptedKeyProcessor.java
Show resolved
Hide resolved
|
Hi @coheigea I would like to draw your attention to the last commit: |
|
@jrihtarsic Yes I think any other changes should go in a new JIRA for now. |
coheigea
requested changes
Jan 25, 2024
ws-security-dom/src/main/java/org/apache/wss4j/dom/processor/EncryptedKeyProcessor.java
Show resolved
Hide resolved
coheigea
approved these changes
Jan 25, 2024
coheigea
pushed a commit
that referenced
this pull request
Jan 25, 2024
* Support for the ECDH KeyAgreement method algorithm * Fix typos, regenerate example keystores using keytool/ * Clean double spaces, NPE validation for KeyAgreement * XDH and EdEC key length validation for AlgorithmSuiteValidator * Add check for KeyAgreement --------- Co-authored-by: RIHTARSIC Joze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR aims to enable the ECDH_ES Key Agreement Algorithm for WSS4J using EC and XEC keys. The details are described in the ticket WSS-706.
The Elliptic-curve Diffie–Hellman ephemeral static algorithm (ECDH_ES) is a key agreement protocol that allows two parties to establish a shared secret over an insecure channel. It is a variant of the Diffie–Hellman protocol using elliptic-curve cryptography.
The code is contributed on behalf of the European Commission’s edelivery project to support eDelivery AS4 2.0 profile.