feat: allow restricting operations for parameter attributes on properties#7899
Draft
Maxcastel wants to merge 2 commits intoapi-platform:mainfrom
Conversation
Maxcastel
changed the title
Maxcastel
force-pushed
the
feature/allow-restricting-operations-for-parameter-attributes-on-properties
branch
from
604e56d to
b6ba5e3
Compare
soyuka
reviewed
Apr 29, 2026
| } | ||
|
|
||
| $propertyName = $reflectionProperty->getName(); | ||
| $key = $parameter->getKey() ?? $propertyName; |
Member
There was a problem hiding this comment.
no functional test for the default propertyName value can you add one?
| $parameter = $attribute->newInstance(); | ||
|
|
||
| if ( | ||
| null !== ($parameterOperations = $parameter->getOperations()) |
Member
There was a problem hiding this comment.
not sure about this, how would it work? Should we declare the parameter on all operations or maybe just GetCollection? Or is it that you give an array of operations to the parameter Parameter(operations: [GetCollection::class]) ? I haven't seen any functional test showing this functionality.
Contributor
Author
There was a problem hiding this comment.
an array of operations to the parameter Parameter(operations: [GetCollection::class]). The operation must also be declared in the ApiResource operations array.
Maxcastel
force-pushed
the
feature/allow-restricting-operations-for-parameter-attributes-on-properties
branch
from
b6ba5e3 to
fcd2878
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #7870
#[ApiResource( operations: [ new GetCollection(), new Get(), ], )] class Book { // Applies to all operations #[QueryParameter(key: 'search', filter: new PartialSearchFilter())] private string $title = ''; // Applies only to GetCollection #[QueryParameter(key: 'name', filter: new PartialSearchFilter(), operations: [new GetCollection()])] public string $name = ''; // Applies only to GetCollection (Patch is not in the list of operations) #[HeaderParameter(key: 'X-Authorization', operations: [new GetCollection(), new Patch()])] public string $authToken = ''; }