Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace old Rinkeby reference #1940

Merged
merged 1 commit into from
Jan 30, 2024
Merged

docs: replace old Rinkeby reference #1940

merged 1 commit into from
Jan 30, 2024

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Jan 27, 2024

The main purpose of this PR is to add a changeset so that the Docker build step of CI stops failing (see #1585 (comment))

@dcroote dcroote requested a review from Siegrift January 27, 2024 06:52
@dcroote dcroote self-assigned this Jan 27, 2024
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, but how did this error happen in the first place 🤔 ?

@dcroote dcroote merged commit e4edd31 into master Jan 30, 2024
28 of 29 checks passed
@dcroote dcroote deleted the dcroote/rinkeby branch January 30, 2024 07:48
@dcroote
Copy link
Contributor Author

dcroote commented Jan 30, 2024

how did this error happen in the first place 🤔 ?

Do you mean why does the absence of a changeset cause CI failure? Or why was there a Rinkeby reference in the README? If the former, this has existed for some time, but only crops up after a release followed by a PR without a changeset. If the latter, I'm guessing when other references to Rinkeby were being removed, this README instance was missed.

@Siegrift
Copy link
Contributor

Yeah I meant the former. I still don't understand this:

but only crops up after a release followed by a PR without a changeset

We have a check that ensures that every PR has a changeset (even empty one). So we should not have this issue 🤔

@dcroote
Copy link
Contributor Author

dcroote commented Jan 30, 2024

We have a check that ensures that every PR has a changeset

Except for Renovate PRs, which is what I happened to merge first after the 0.14 release 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants