Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove display of V1 treasury #110

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Remove display of V1 treasury #110

merged 2 commits into from
Dec 11, 2024

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Dec 3, 2024

Closes #103. Tested locally, with the result being (relative to the treasuries page):

image

@dcroote dcroote requested a review from aquarat December 3, 2024 07:17
@dcroote dcroote self-assigned this Dec 3, 2024
Copy link
Contributor

@aquarat aquarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A surprisingly simple change 😄

But this doesn't stop it collecting and processing events for the V1 treasury... but I guess that's not a big deal?

The treasury tracking code seems to only get and store the current state:

const v1 = webconfig.contracts?.find(
({ name }) => name.toLowerCase() === "v1treasury",
)?.address;
(as opposed to complex event tracking)

@dcroote
Copy link
Contributor Author

dcroote commented Dec 10, 2024

But this doesn't stop it collecting and processing events for the V1 treasury... but I guess that's not a big deal?

Good point. I don't think it's worth trying to rip out the V1 treasury from the DB or mess with the storage / retrieval logic, so as a compromise I've now replaced the RPC calls with 0 for the V1 treasury token values (analogous to #111 (comment)).

Copy link
Contributor

@aquarat aquarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@aquarat aquarat merged commit 7a1791d into main Dec 11, 2024
3 checks passed
@aquarat aquarat deleted the rm-v1-treasury branch December 11, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the DAOv1 treasury
2 participants