Skip to content

Commit

Permalink
Return None/Null instead of 0 for empty input
Browse files Browse the repository at this point in the history
  • Loading branch information
evgenii-kuznetcov committed Nov 18, 2024
1 parent 97526fb commit 2045914
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "polars-tdigest"
version = "0.1.4"
version = "0.1.5"
edition = "2021"

[lib]
Expand Down
9 changes: 7 additions & 2 deletions src/expressions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,11 @@ fn estimate_quantile(inputs: &[Series], kwargs: MergeTDKwargs) -> PolarsResult<S

let tdigests: Vec<TDigest> = tdigest_json.into_iter().map(|td| td.tdigest).collect();
let tdigest = TDigest::merge_digests(tdigests);
let ans = tdigest.estimate_quantile(kwargs.quantile);
Ok(Series::new("", vec![ans]))
if tdigest.is_empty() {
let v: &[Option<f64>] = &[None];
Ok(Series::new("", v))
} else {
let ans = tdigest.estimate_quantile(kwargs.quantile);
Ok(Series::new("", vec![ans]))
}
}

0 comments on commit 2045914

Please sign in to comment.