Don't return NaN values for empty clusters #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenii-kuznetcov
force-pushed
the
fix-nan
branch
from
31d4479 to
553a1a5
Compare
evgenii-kuznetcov
changed the title
evgenii-kuznetcov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no data to compute
TDigest,TDigest::defaultis returned. This struct containsNaNs.When this value is sent back to polars during reduction step, it's not deserialized properly and rust code panics.
This is a minimal fix. Later error handling should be improved to turn panic into a proper error