exposed function to merge tdigest with small refactoring #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/expressions.rs
Outdated
| let file = Cursor::new(&td_json); | ||
| let df = JsonReader::new(file) | ||
| .with_json_format(JsonFormat::JsonLines) | ||
| .infer_schema_len(Some(3)) |
There was a problem hiding this comment.
We know the schema beforehand, so there is no need to infer it. We already have .with_schema(Arc::new(Schema::from_iter(tdigest_fields()))) in another place. Also I faced the problem that infer_schema doesn't work if the input is empty
There was a problem hiding this comment.
good catch. I replaced this in both places where we had still used this
There was a problem hiding this comment.
Thanks, then LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as in the closed PR, but with small refactoring