-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update electron-builder and Azure pipeline configurations #1404
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7e9b714
ci: update azure VM images
eglitise bd1c26f
ci: update Node for Azure
eglitise 5b3a02a
ci: always publish in x64 and arm64
eglitise 425817f
ci: move electron-builder config into own file for clarity
eglitise ea8e566
ci: remove electron-builder nsisWeb option
eglitise 8743b0c
ci: slightly adjust common package options
eglitise 30cf493
ci: remove electron-build filepaths already included by default
eglitise 25223ed
ci: use common artifact name format
eglitise f9ab6c8
ci: omit repeating default paths to app icon
eglitise 08e0b0b
ci: build separate artifacts for both mac architectures
eglitise 736f570
ci: add tar.gz target for Linux
eglitise 06b33c5
ci: add entitlements file for mac signing
eglitise 4ddec91
chore: fix syntax for Azure UseNode task
eglitise File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>com.apple.security.cs.allow-jit</key> | ||
| <true/> | ||
| </dict> | ||
| </plist> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| { | ||
| "productName": "Appium Inspector", | ||
| "appId": "io.appium.inspector", | ||
| "asar": true, | ||
| "directories": { | ||
| "output": "release" | ||
| }, | ||
| "files": ["dist/", "main.js", "main.js.map"], | ||
| "artifactName": "${productName}-${version}-${os}-${arch}.${ext}", | ||
| "fileAssociations": [ | ||
| { | ||
| "ext": "appiumsession", | ||
| "name": "Appium Session", | ||
| "role": "Editor" | ||
| } | ||
| ], | ||
| "mac": { | ||
| "category": "public.app-category.developer-tools" | ||
| }, | ||
| "dmg": { | ||
| "contents": [ | ||
| { | ||
| "x": 410, | ||
| "y": 150, | ||
| "type": "link", | ||
| "path": "/Applications" | ||
| }, | ||
| { | ||
| "x": 130, | ||
| "y": 150, | ||
| "type": "file" | ||
| } | ||
| ] | ||
| }, | ||
| "win": { | ||
| "target": ["nsis", "zip"] | ||
| }, | ||
| "nsis": { | ||
| "oneClick": false | ||
| }, | ||
| "linux": { | ||
| "target": ["AppImage", "tar.gz"], | ||
| "category": "Development" | ||
| }, | ||
| "publish": { | ||
| "provider": "github", | ||
| "owner": "appium", | ||
| "vPrefixedTagName": true | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider using lts node version alias instead of the hardcoded one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if Azure supports the
ltsvalue. The documentation only refers to semver values.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I forgot it's Azure. Perhaps it makes sense to migrate to GitHub CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that GitHub CI would be more convenient, though I'm guessing there was a reason why Azure was originally selected. Maybe the machines are more powerful? It's also used in other Appium projects (e.g. xcuitest driver).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was selected before github had any CI. Yes, it is still used, although not by xcuitest driver. It's used in webdriveragent because of the high amount of e2e tests we run there and the limited capability of free macOS-based runners on Github. Otherwise I would also migrate them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I tried to convert this project to GHA before. Then, I needed maybe Window's signature which probably needed Dan's help. We could restart migrating them.