chore: refactor session detail storage & retrieval #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
| desiredCapabilities = addCustomCaps(desiredCapabilities); | ||
| let sessionCaps = originalCaps ? getCapsObject(originalCaps) : {}; | ||
| let host, port, username, accessKey, https, path, headers; | ||
| sessionCaps = addCustomCaps(sessionCaps); | ||
|
|
||
| switch (session.serverType) { | ||
| case SERVER_TYPES.LOCAL: |
There was a problem hiding this comment.
I believe in the future it makes sense to modularize this switch, so we keep all vendor-specific capability transformers (as well as other vendor-specific stuff) in separate modules, for example, sauce.js or perfecto.js, which must implement one common base interface (defined by us)
There was a problem hiding this comment.
I fully agree, but that would also make this PR a lot bigger, so I would prefer to have a separate PR for that
There was a problem hiding this comment.
ofc, not in the same PR
mykola-mokhnach
approved these changes
Feb 16, 2025
KazuCocoa
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily a refactoring PR for the Session Information screen, but also adjusts the data format used when storing the initial session details, which is also used in the Session Information screen:
getSessioncall into a separate method for consistencyisUsingMjpegModeinstead of implicitly convertingmjpegScreenshotUrlto boolean