Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to use HTTPS for swift-distributed-tracing-baggage #25

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Updated to use HTTPS for swift-distributed-tracing-baggage #25

merged 2 commits into from
Dec 4, 2020

Conversation

0xLeif
Copy link
Contributor

@0xLeif 0xLeif commented Dec 4, 2020

No description provided.

@swift-server-bot
Copy link

Can one of the admins verify this patch?

4 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@0xLeif 0xLeif changed the title Updated to use HTTPS Updated to use HTTPS for swift-distributed-tracing-baggage Dec 4, 2020
@ktoso
Copy link
Member

ktoso commented Dec 4, 2020

@swift-server-bot test this please

@ktoso
Copy link
Member

ktoso commented Dec 4, 2020

Thanks a lot @0xLeif! The fix was meant to get in earlier but sadly everyone else with review/write rights is asleep and I could not approve my own PR 😅

We need to make the same change in swift-distributed-tracing-baggage, and I'll tag an 0.1.1 of projects so one can ensure to depend on the actually working dependency chain.

@0xLeif
Copy link
Contributor Author

0xLeif commented Dec 4, 2020

Thanks a lot @0xLeif! The fix was meant to get in earlier but sadly everyone else with review/write rights is asleep and I could not approve my own PR 😅

We need to make the same change in swift-distributed-tracing-baggage, and I'll tag an 0.1.1 of projects so one can ensure to depend on the actually working dependency chain.

I have a PR for swift-distributed-tracing-baggage here

@ktoso
Copy link
Member

ktoso commented Dec 4, 2020

@swift-server-bot test this please

@ktoso ktoso merged commit f4c06f0 into apple:main Dec 4, 2020
@slashmo slashmo mentioned this pull request Dec 8, 2020
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xLeif @swift-server-bot @ktoso