Android support #244
Merged
Android support #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there any indication of what it doesn't like? The action log at https://github.com/apple/swift-nio-extras/actions/runs/12766669331/job/35592455040?pr=244 just reports a failure without any diagnostic message. |
|
It wants you to apply this diff: |
Done in 63cf347 |
glbrntt
approved these changes
Jan 14, 2025
mergify bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Feb 11, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [vapor/vapor](https://redirect.github.com/vapor/vapor) | minor | `4.112.1` -> `4.113.0` | --- ### Release Notes <details> <summary>vapor/vapor (vapor/vapor)</summary> ### [`v4.113.0`](https://redirect.github.com/vapor/vapor/releases/tag/4.113.0): - Fix warnings from NIO 2.79.0 [Compare Source](https://redirect.github.com/vapor/vapor/compare/4.112.2...4.113.0) #### What's Changed Fix warnings from NIO 2.79.0 by [@​0xTim](https://redirect.github.com/0xTim) in [#​3285](https://redirect.github.com/vapor/vapor/issues/3285) > Fixes a number of `Sendable` warnings introduced by https://github.com/apple/swift-nio/releases/tag/2.79.0 > > This also deprecates the main `Application.init()` API that was blocking on an event loop that has been marked as `noasync` for a while. Vapor users should migrate to the async APIs. ###### *This patch was released by [@​0xTim](https://redirect.github.com/0xTim)* **Full Changelog**: vapor/vapor@4.112.2...4.113.0 ### [`v4.112.2`](https://redirect.github.com/vapor/vapor/releases/tag/4.112.2): - Android support [Compare Source](https://redirect.github.com/vapor/vapor/compare/4.112.1...4.112.2) #### What's Changed Android support by [@​marcprux](https://redirect.github.com/marcprux) in [#​3282](https://redirect.github.com/vapor/vapor/issues/3282) > This PR adds experimental support for building and testing on Android. It simply involves adding some conditional imports. > > Building is contingent on [apple/swift-distributed-tracing#163](https://redirect.github.com/apple/swift-distributed-tracing/pull/163), [apple/swift-http-structured-headers#57](https://redirect.github.com/apple/swift-http-structured-headers/pull/57), [swift-server/async-http-client#799](https://redirect.github.com/swift-server/async-http-client/pull/799), and [apple/swift-nio-extras#244](https://redirect.github.com/apple/swift-nio-extras/pull/244), but if you use local snapshots of those packages, you can build with the [Android SDK](https://redirect.github.com/finagolfin/swift-android-sdk) using: > > ~/Library/Developer/Toolchains/swift-6.0.3-RELEASE.xctoolchain/usr/bin/swift build --swift-sdk aarch64-unknown-linux-android24 --build-tests ###### *This patch was released by [@​0xTim](https://redirect.github.com/0xTim)* **Full Changelog**: vapor/vapor@4.112.1...4.112.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45NC4xIiwidXBkYXRlZEluVmVyIjoiMzguOTQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: cgrindel-self-hosted-renovate[bot] <139595543+cgrindel-self-hosted-renovate[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Android support
Motivation:
Support the Android platform.
Modifications:
Add Android imports and fix the default temporary directory to be correct for the OS.
Result:
The package will build and test on Android.