HTTPDecoder: Preserve maxHeaderFieldSize accounting across header name/value transition - #3690
Open
5H4D0WBY73 wants to merge 2 commits into
Open
HTTPDecoder: Preserve maxHeaderFieldSize accounting across header name/value transition#36905H4D0WBY73 wants to merge 2 commits into
5H4D0WBY73 wants to merge 2 commits into
Conversation
Preserve currentFieldByteLength across the header name → header value transition so maxHeaderFieldSize is enforced across the complete header field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the accounting of
maxHeaderFieldSizeacross the header name → header value transition.Previously,
finish()was called when transitioning fromheaderNametoheaderValue, which resetcurrentFieldByteLengthbefore the header value was parsed. As a result,maxHeaderFieldSizewas enforced independently on the header name and header value instead of on the complete header field, contrary to the documented behavior.This change introduces a
flush()helper that forwards the accumulated bytes without resettingcurrentFieldByteLength.finish()now delegates toflush()before resetting the counter, and the header name → header value transition usesflush()instead offinish().As a result, the byte counter is preserved across the transition and
maxHeaderFieldSizeis enforced on the complete header field (name + value) as documented.Changes
flush()to separate flushing from counter reset.currentFieldByteLengthacross the header name → header value transition.This PR implements the fix discussed in GHSA-f4r8-q66f-vf84.