Skip to content

Drop private(set) where @inlinable code writes the property #3703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karpovantonme wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −13
Open

Drop private(set) where @inlinable code writes the property #3703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
841e53e
Make Heap.storage's setter usable from inlinable code
karpovantonme Aug 13, 2026
cc3c89e
Do the same for the 12 other properties the diagnostic names
karpovantonme Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Sources/NIOCore/ByteBuffer-core.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ extension _ByteBufferSlice: Equatable {}
/// fits within 24 bits, otherwise the behaviour is undefined.
@usableFromInline
struct _ByteBufferSlice: Sendable {
@usableFromInline private(set) var upperBound: ByteBuffer._Index
@usableFromInline private(set) var _begin: _UInt24
@usableFromInline var upperBound: ByteBuffer._Index
@usableFromInline var _begin: _UInt24
@inlinable var lowerBound: ByteBuffer._Index {
UInt32(self._begin)
}
Expand Down Expand Up @@ -324,8 +324,8 @@ public struct ByteBuffer {
// MARK: Internal _Storage for CoW
/// Note: This class is **not** thread-safe
@usableFromInline final class _Storage {
@usableFromInline private(set) var capacity: _Capacity
@usableFromInline private(set) var bytes: UnsafeMutableRawPointer
@usableFromInline var capacity: _Capacity
@usableFromInline var bytes: UnsafeMutableRawPointer
@usableFromInline let allocator: ByteBufferAllocator

@inlinable
Expand Down
12 changes: 6 additions & 6 deletions Sources/NIOCore/CircularBuffer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@
/// expansions from happening frequently. Expansions will always force an allocation and a copy to happen.
public struct CircularBuffer<Element>: CustomStringConvertible {
@usableFromInline
internal private(set) var _buffer: ContiguousArray<Element?>
internal var _buffer: ContiguousArray<Element?>

@usableFromInline
internal private(set) var headBackingIndex: Int
internal var headBackingIndex: Int

@usableFromInline
internal private(set) var tailBackingIndex: Int
internal var tailBackingIndex: Int

@inlinable
internal var mask: Int {
Expand Down Expand Up @@ -63,9 +63,9 @@ public struct CircularBuffer<Element>: CustomStringConvertible {
/// - Note: Every index is invalidated as soon as you perform a length-changing operating on the `CircularBuffer`
/// but remains valid when you replace one item by another using the subscript.
public struct Index: Comparable, Sendable {
@usableFromInline private(set) var _backingIndex: UInt32
@usableFromInline private(set) var _backingCheck: _UInt24
@usableFromInline private(set) var isIndexGEQHeadIndex: Bool
@usableFromInline var _backingIndex: UInt32
@usableFromInline var _backingCheck: _UInt24
@usableFromInline var isIndexGEQHeadIndex: Bool

@inlinable
internal var backingIndex: Int {
Expand Down
4 changes: 2 additions & 2 deletions Sources/NIOCore/SingleStepByteToMessageDecoder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,11 @@ public final class NIOSingleStepByteToMessageProcessor<Decoder: NIOSingleStepByt
}

@usableFromInline
internal private(set) var decoder: Decoder
internal var decoder: Decoder
@usableFromInline
let maximumBufferSize: Int?
@usableFromInline
internal private(set) var _buffer: ByteBuffer?
internal var _buffer: ByteBuffer?

/// Initialize a `NIOSingleStepByteToMessageProcessor`.
///
Expand Down
2 changes: 1 addition & 1 deletion Sources/_NIODataStructures/Heap.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import ucrt
@usableFromInline
internal struct Heap<Element: Comparable> {
@usableFromInline
internal private(set) var storage: [Element]
internal var storage: [Element]

@inlinable
internal init() {
Expand Down