Skip to content

[Performance] Mark QUICBinaryEncodingStrategy.bytesNeededForInteger as @inlinable #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fabianfett wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

[Performance] Mark QUICBinaryEncodingStrategy.bytesNeededForInteger as @inlinable #3718

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38b5e9d
[Performance] Mark `bytesNeededForInteger` as `@inlinable`
fabianfett Aug 24, 2026
769cd4e
order
fabianfett Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Sources/NIOCore/ByteBuffer-quicBinaryEncodingStrategy.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ extension ByteBuffer {
/// Calculates the minimum number of bytes needed to encode an integer using this strategy
/// - Parameter integer: The integer to be encoded
/// - Returns: The number of bytes needed to encode it
@inlinable
public static func bytesNeededForInteger<IntegerType: FixedWidthInteger>(_ integer: IntegerType) -> Int {
// We must cast the integer to UInt64 here
// Otherwise, an integer can fall through to the default case
Expand Down Expand Up @@ -129,17 +130,17 @@ extension ByteBuffer {
}

extension NIOBinaryIntegerEncodingStrategy where Self == ByteBuffer.QUICBinaryEncodingStrategy {
@inlinable
/// Encodes bytes as defined in RFC 9000 § 16
/// - Parameter requiredBytesHint: An estimate of the bytes required to write integers using this strategy. This parameter is only relevant if calling ``ByteBuffer/writeLengthPrefixed(strategy:writeData:)``
/// - Returns: An instance of ``ByteBuffer/QUICBinaryEncodingStrategy``
@inlinable
public static func quic(
requiredBytesHint: ByteBuffer.QUICBinaryEncodingStrategy.IntegerLength
) -> ByteBuffer.QUICBinaryEncodingStrategy {
ByteBuffer.QUICBinaryEncodingStrategy(requiredBytesHint: requiredBytesHint)
}

@inlinable
/// Encodes bytes as defined in RFC 9000 § 16
@inlinable
public static var quic: ByteBuffer.QUICBinaryEncodingStrategy { .quic(requiredBytesHint: .four) }
}
Loading