feat: add support for insecure TLS connections #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `crypto/tls` import in `jenkins.go` - Add `Client` field to `Jenkins` struct - Modify `NewJenkins` function to accept an `insecure` parameter and configure HTTP client accordingly - Update `sendRequest` method to use the `Client` field from the `Jenkins` struct - Update tests in `jenkins_test.go` to include the `insecure` parameter in `NewJenkins` calls - Add `insecure` flag to CLI options in `main.go` - Add `Insecure` field to `Plugin` struct - Update `Plugin.Exec` method to pass `Insecure` field to `NewJenkins` Signed-off-by: appleboy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crypto/tlsimport injenkins.goClientfield toJenkinsstructNewJenkinsfunction to accept aninsecureparameter and configure HTTP client accordinglysendRequestmethod to use theClientfield from theJenkinsstructjenkins_test.goto include theinsecureparameter inNewJenkinscallsinsecureflag to CLI options inmain.goInsecurefield toPluginstructPlugin.Execmethod to passInsecurefield toNewJenkins