Prevent Stack Overflow when using Project Auditor with Newtonsoft.Json-for-Unity.Converters#100
Open
AhmadMansy wants to merge 2 commits intoapplejag:masterfrom
Open
Prevent Stack Overflow when using Project Auditor with Newtonsoft.Json-for-Unity.Converters#100AhmadMansy wants to merge 2 commits intoapplejag:masterfrom
AhmadMansy wants to merge 2 commits intoapplejag:masterfrom
Conversation
Added an exclusion mechanism to `ConverterGrouping.cs` that prevents problematic converters from being automatically registered
…-Project-Auditor-package Project Auditor Stack Overflow Fix
2 tasks
Owner
|
Thanks for the contribution! But I want to note that I will not merge this because the CI/CD system is not working and I don't have time nor energy to debug it. So I cannot run the tests and I cannot create a new release. |
Author
No problem, I also left a comment in the issue with a link for the fork, anyone can use it as git or manual. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98
This PR resolves a stack overflow that freezes Unity when the Project Auditor window is opened.
The issue was that the auto-discovery was registering Project Auditor's own
DescriptorJsonConverter, creating an infinite recursion loop when it tried to serialize its own data.To fix this, I've added an exclusion mechanism in
ConverterGrouping.csto skip registering specific converters by type or by namespace. I've added default exclusions forUnity.ProjectAuditor.Editor.Core.DescriptorJsonConverterand the entireUnity.ProjectAuditornamespace, which prevents the crash.