generated from appvia/terraform-aws-module-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "quicksight" identify type, update cfn caller templates + clearer admin user/dashboard user creation #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Review Status
Working Directory: |
d659fc7
to
e35cb39
Compare
7950dfd
to
81ee920
Compare
…rraform-aws-cudos into fix/non-iam-auth-error
98125a7
to
29cdcf0
Compare
29cdcf0
to
5ca4f9e
Compare
gambol99
approved these changes
Feb 28, 2025
LGTM .. thank you kindly 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some fixes discovered during a new deployment.
v0.2.0
to fix an issue with the remote stacks requiring new inputs.enable_quicksight_admin
in order for an admin user to be created (username/email configurable as before)var.quicksights_username
renamed tovar.quicksight_dashboard_owner
to increase clarity around what this user/input is used for.The default logic is now that the destination module will create an admin user 'admin' and that same user will be used as the dashboards owner. The local to evaluate whether an admin user should be created or not is removed so that a terraform error is raised when
enable_quicksight_admin=true
andvar.quicksight_admin_email
has not be set (due toemail
being a required attr for theaws_quicksight_user
resource. You will be able to stop this module managing the admin user by settingenable_quicksight_admin=false