docs: add additional module documentation#66
Merged
Conversation
Pull Request Review Status
Working Directory: |
Pull Request Review Status
Working Directory: |
Pull Request Review Status
Working Directory: |
ssun3
force-pushed
the
docs/add-documentation
branch
5 times, most recently
from
a230069 to
444fc2f
Compare
ssun3
commented
May 28, 2025
| # GitLab includes environment info as separate JWT claims (environment, deployment_tier) | ||
| # rather than in the subject claim. Need to use custom claim conditions for environment-based access. | ||
| # setting this to empty string to avoid null value error for now. | ||
| subject_env_mapping = "" |
Contributor
Author
There was a problem hiding this comment.
TODO in separate PR: Add subject_env_mapping support for GitLab. Since GitLab passes environment/deployment_tier as separate JWT claims (not in the subject), implementing this properly requires refactoring the module's claim parsing logic beyond just config changes. Setting to empty string for now.
ssun3
force-pushed
the
docs/add-documentation
branch
2 times, most recently
from
46f916f to
0abbb55
Compare
Add additional documentation for Terraform AWS OIDC integration: - Architecture overview and system design - Hidden dependencies and prerequisites - Step-by-step setup guide - Examples analysis with security considerations - Security best practices and hardening guidelines - Troubleshooting guide and common issues
Added documentation explaining that GitLab provides environment information as separate JWT claims rather than in the subject claim, requiring custom claim conditions for environment-based access control.
- Added mock providers for AWS and TLS in test files - Enhanced custom provider test coverage - Added tags to test resources for better organization
ssun3
force-pushed
the
docs/add-documentation
branch
from
0abbb55 to
0c4ba59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional documentation for Terraform AWS OIDC integration:
Additional improvements: